Add Local Server extension for containers #525
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikelittle
reviewed
Sep 20, 2024
| * @return array Altered docker-compose.yml configuration. | ||
| */ | ||
| public function filter_compose( array $config ) : array { | ||
| // Skip entirely if the module is disabled. |
There was a problem hiding this comment.
I don't like the similarity between the different "config" var names.
Two are the composer config, and one is a docker-compose config. Could they be called full/local_composer_config and docker_config?
| $version_map = [ | ||
| '7.10' => 'humanmade/altis-local-server-kibana:1.1.1', | ||
| '7' => 'humanmade/altis-local-server-kibana:1.1.1', | ||
| '6.8' => 'blacktop/kibana:6.8', |
There was a problem hiding this comment.
A thought. Why are we still supporting so many old versions? Is this just for clients who haven't upgraded? Or is there a technical reason someone would want to use an old version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires humanmade/altis-local-server#723 - see humanmade/altis-local-server#722 for more context.