Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experience Blocks #24

Merged
merged 44 commits into from
Jun 5, 2020
Merged

Experience Blocks #24

merged 44 commits into from
Jun 5, 2020

Commits on May 11, 2020

  1. First draft experience blocks

    @roborourke
    roborourke committed May 11, 2020
    Configuration menu
    Copy the full SHA
    7507d69 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2020

  1. add eslint and fix code style issues

    @roborourke
    roborourke committed May 12, 2020
    Configuration menu
    Copy the full SHA
    ad4bf72 View commit details
    Browse the repository at this point in the history

  2. record an event when an XB is viewed

    @roborourke
    roborourke committed May 12, 2020
    Configuration menu
    Copy the full SHA
    bc20304 View commit details
    Browse the repository at this point in the history

  3. Fix nodelist iterator

    @roborourke
    roborourke committed May 12, 2020
    Configuration menu
    Copy the full SHA
    beea777 View commit details
    Browse the repository at this point in the history

  4. Web components cannot be self closing

    @roborourke
    roborourke committed May 12, 2020
    Configuration menu
    Copy the full SHA
    07dc288 View commit details
    Browse the repository at this point in the history

  5. Fix positioning of the audience picker component

    @roborourke
    roborourke committed May 12, 2020
    Configuration menu
    Copy the full SHA
    7dc8b51 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2020

  1. Test load experiments.js async

    @roborourke
    roborourke committed May 13, 2020
    Configuration menu
    Copy the full SHA
    de274dc View commit details
    Browse the repository at this point in the history

Commits on May 14, 2020

  1. remove URLInput in favour of UI from main analytics plugin

    @roborourke
    roborourke committed May 14, 2020
    Configuration menu
    Copy the full SHA
    214d516 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2020

  1. Adding UI polish plus copy function

    @roborourke
    roborourke committed May 16, 2020
    Configuration menu
    Copy the full SHA
    8965c19 View commit details
    Browse the repository at this point in the history

  2. fix white space error

    @roborourke
    roborourke committed May 16, 2020
    Configuration menu
    Copy the full SHA
    2ea9fb5 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2020

  1. switch to using webpack manifest plugin

    @roborourke
    roborourke committed May 18, 2020
    Configuration menu
    Copy the full SHA
    6110a33 View commit details
    Browse the repository at this point in the history

  2. Fix initial XB insert logic, innerBlocks template wasnt working

    @roborourke
    roborourke committed May 18, 2020
    Configuration menu
    Copy the full SHA
    f5e6834 View commit details
    Browse the repository at this point in the history

  3. Support for using audience names or fallback for variant

    @roborourke
    roborourke committed May 18, 2020
    Configuration menu
    Copy the full SHA
    bb0b6e5 View commit details
    Browse the repository at this point in the history

  4. fix linter errors

    @roborourke
    roborourke committed May 18, 2020
    Configuration menu
    Copy the full SHA
    5589659 View commit details
    Browse the repository at this point in the history

  5. Dont uppercase the XB header

    @roborourke
    roborourke committed May 18, 2020
    Configuration menu
    Copy the full SHA
    19ee037 View commit details
    Browse the repository at this point in the history

  6. Ensure custom elements are only defined when analytics.js has loaded

    @roborourke
    roborourke committed May 18, 2020
    Configuration menu
    Copy the full SHA
    67c2db3 View commit details
    Browse the repository at this point in the history

  7. expose Test.registerGoal before defining custom elements

    @roborourke
    roborourke committed May 18, 2020
    Configuration menu
    Copy the full SHA
    0fe1fa2 View commit details
    Browse the repository at this point in the history

  8. Ensure BuildURL is defined for file chunks

    @roborourke
    roborourke committed May 18, 2020
    Configuration menu
    Copy the full SHA
    80b8b23 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2020

  1. Add missing docblocks and fix use statements

    @roborourke
    roborourke committed May 20, 2020
    Configuration menu
    Copy the full SHA
    73b2a7f View commit details
    Browse the repository at this point in the history

Commits on May 22, 2020

  1. rename block to personalized content and add XB block category

    @roborourke
    roborourke committed May 22, 2020
    Configuration menu
    Copy the full SHA
    5366588 View commit details
    Browse the repository at this point in the history

  2. Improve personalised content block header styling for dark backgrounds

    @roborourke
    roborourke committed May 22, 2020
    Configuration menu
    Copy the full SHA
    d75ce8f View commit details
    Browse the repository at this point in the history

Commits on May 27, 2020

  1. Bind setContent to the current instance

    @rmccue
    rmccue committed May 27, 2020
    Configuration menu
    Copy the full SHA
    624fbac View commit details
    Browse the repository at this point in the history

  2. Merge pull request #27 from humanmade/bind-setcontent 

    Bind setContent to EB instance
    @roborourke
    roborourke authored May 27, 2020
    Configuration menu
    Copy the full SHA
    3905c75 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2020

  1. Use explicit fallback block that cannot be removed

    @roborourke
    roborourke committed May 28, 2020
    Configuration menu
    Copy the full SHA
    bedb416 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2020

  1. compare json_last_error() to JSON_ERROR_NONE constant 

    Co-authored-by: Ryan McCue <me@ryanmccue.info>
    @roborourke @rmccue
    roborourke and rmccue authored May 29, 2020
    Configuration menu
    Copy the full SHA
    d503042 View commit details
    Browse the repository at this point in the history

  2. Pre fetch posts and only re-render XB when isLoading changes

    @roborourke
    roborourke committed May 29, 2020
    Configuration menu
    Copy the full SHA
    371ccf8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'experience-blocks' of github.com:humanmade/experiments … 

    …into experience-blocks
    @roborourke
    roborourke committed May 29, 2020
    Configuration menu
    Copy the full SHA
    f04b669 View commit details
    Browse the repository at this point in the history

  4. Use component for rendering variant title

    @roborourke
    roborourke committed May 29, 2020
    Configuration menu
    Copy the full SHA
    a38ed58 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2020

  1. Code review improvements 

    Reorganising code into additional smaller components.

Fix incorrect phpcs ignore directives.
    @roborourke
    roborourke committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    588d445 View commit details
    Browse the repository at this point in the history

  2. Commit new component files

    @roborourke
    roborourke committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    5e20d29 View commit details
    Browse the repository at this point in the history

  3. Check if audience is set on client side rather than fallback var

    @roborourke
    roborourke committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    f6db732 View commit details
    Browse the repository at this point in the history

  4. Add missing semi colons

    @roborourke
    roborourke committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    a7f54ae View commit details
    Browse the repository at this point in the history

  5. Fix operator spacing

    @roborourke
    roborourke committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    50b5d2f View commit details
    Browse the repository at this point in the history

  6. Check for error on audience object in VariantTitle

    @roborourke
    roborourke committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    ea18161 View commit details
    Browse the repository at this point in the history

  7. Use plugin file constant for plugins_url() calls

    @roborourke
    roborourke committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    4d038a3 View commit details
    Browse the repository at this point in the history

  8. Check audience status for trash as well API error

    @roborourke
    roborourke committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    d421491 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2020

  1. Rename callback to be prefixed with on*

    @roborourke
    roborourke committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    73b10f5 View commit details
    Browse the repository at this point in the history

  2. Fix styling for WP 5.4

    @roborourke
    roborourke committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    bc7e45e View commit details
    Browse the repository at this point in the history

  3. Fix flexbox toolbar issues

    @roborourke
    roborourke committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    f064ad8 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2020

  1. Merge master

    @roborourke
    roborourke committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    218e43c View commit details
    Browse the repository at this point in the history

  2. Fix minor coding standards pieces

    @rmccue
    rmccue authored Jun 4, 2020
    Configuration menu
    Copy the full SHA
    d1514b0 View commit details
    Browse the repository at this point in the history

  3. Simplify some tidbits

    @rmccue
    rmccue authored Jun 4, 2020
    Configuration menu
    Copy the full SHA
    ac81eca View commit details
    Browse the repository at this point in the history

  4. Correct a misspellling

    @rmccue
    rmccue authored Jun 4, 2020
    Configuration menu
    Copy the full SHA
    ddc9dd0 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2020

  1. Use ROOT_FILE for title ab test asset URL

    @roborourke
    roborourke committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    e59f4fc View commit details
    Browse the repository at this point in the history