dependency upgrade #188
Open
dependency upgrade #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In another run, today, I replaced the use of jQuery. I also tried replacing the version of imgareaselect with the one from WP v.5.5.9, but that didn't help my issue, either. |
|
Looks like this is also would solve my problem. Any update on this? |
|
It should be using whatever version of imgareaselect is bundled with WP, I thought it had the appropriate compat but perhaps not. I think at this point it'd be ideal to look at removing the jQuery dependency altogether. |
|
@roborourke jQuery already has been removed in this PR 😃 |
|
🤦 sorry, code blind today clearly! |
|
😄 happens to the best! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I've been trying to fix an issue we've been having with the plugin at work (#187). I did not succeed in fixing the issue, but maybe you'd like to merge the upgraded dependencies? I'm only opening the PR so that maybe not all of my work on this plugin has been for nothing.
I replaced node-sass with dart-sass, because node-sass was causing an error during installation on my machine – in my experience dart-sass (npm:sass) is way more reliable, anyway, especially in combination with webpack/sass-loader.
Also I replaced the deprecated @babel/polyfills package with core-js as recommended in the babel documentation, while sticking to your defined browser target. Also the "^" were removed from the package.json so that one does not have to look into the package-lock.json in order to find out the exact installed versions – I can, of course, change that back for you, if you don't like it.