Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

143: Fix issue when specifying a false condition for using webp #144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

143: Fix issue when specifying a false condition for using webp #144

wants to merge 1 commit into from

Commits on May 3, 2022

  1. Fix issue when specifying a false condition for using webp 

    `args.webp` is a string by default, so using a conditional with a string in it will always be true unless it is an empty string. This gives a very odd results to have to use `webp=` in order to force using a jpeg. Converting the parameter to a boolean fixes potential issues where future conditionals are just using `(args.webp)` where any string > 0 characters, is equal to true. In addition a conditional which doesn’t consider the datatype allows most strings to be false and `1` to be true as defined in the docs.
    @smccafferty
    smccafferty committed May 3, 2022
    Configuration menu
    Copy the full SHA
    6e22282 View commit details
    Browse the repository at this point in the history