Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Uniswap Liquidity Error #225 [WIP] #257

Closed
wants to merge 11 commits into from

Conversation

mlguys
Copy link
Contributor

@mlguys mlguys commented Dec 21, 2023

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
Solution for fixing this issue: #225

  • Adding better logs for getting liquidity positions and collecting fees
  • Fixing instance where transactions to get position info and collect fees got rejected

Tests performed by the developer:

  • Run uniswap_v3_lp strategy on ARB-USDC.e on pair on Arbitrum for several hours

Tips for QA testing:

@mlguys mlguys changed the title Fix/Uniswap Liquidity Error #225 Fix/Uniswap Liquidity Error #225 [WIP] Dec 21, 2023
@rapcmia rapcmia requested review from rapcmia and nikspz January 5, 2024 14:03
@nikspz nikspz closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants