Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/ Osmosis Chain/Connector #277

Merged
merged 32 commits into from
Mar 15, 2024
Merged
Show file tree
Hide file tree
Changes from 21 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
c548141
feat/Osmosis Chain - clean merge
chasevoorhees Jan 20, 2024
35262e3
fix pool import osmojs
chasevoorhees Jan 26, 2024
554cf5a
Merge branch 'hummingbot:development' into development
chasevoorhees Jan 26, 2024
69c7eaf
remove no-jest debug file
chasevoorhees Jan 27, 2024
f63303a
change default pw for cert manager in osmo tests
chasevoorhees Jan 27, 2024
2195729
re-add osmo assets json files
chasevoorhees Jan 27, 2024
34cab97
fixed cosmos file asset load
chasevoorhees Jan 28, 2024
c508a7e
fix wallet add
chasevoorhees Jan 28, 2024
3c68dd8
amm/trade bigint serialize error
chasevoorhees Jan 31, 2024
3bed751
fix bigint serialize issue with osmo trade. also entirely moved from …
chasevoorhees Feb 1, 2024
6f60437
swagger defs update for poolId->tokenId changes
chasevoorhees Feb 1, 2024
f04cc9d
re-enable addPositionCL, but its throwing null pointer error from the…
chasevoorhees Feb 1, 2024
a129397
fixed CL positions get and reduce
chasevoorhees Feb 2, 2024
c7443f0
Fix network return name for osmo chains/balances
chasevoorhees Feb 5, 2024
97af83a
remove address required in poolPrices()
chasevoorhees Feb 6, 2024
c26fcf5
fixed approvals when interacting with client
chasevoorhees Feb 6, 2024
e1bd11c
Merge branch 'development' into development
chasevoorhees Feb 6, 2024
65e1ecc
update curl.sh and osmosis_trade.json
nkhrs Feb 12, 2024
e94bf8e
changed tests to use ION-OSMO for CL pools since ATOM-OSMO pools were…
chasevoorhees Feb 15, 2024
77ba322
updated osmo tests to use mainnet when specified
chasevoorhees Feb 15, 2024
74a51b1
fixed our testnet CL add/remove again
chasevoorhees Feb 15, 2024
22456b9
Merge branch 'development' into development
chasevoorhees Feb 16, 2024
19c229e
removed osmo test-no-jest file used for debug
chasevoorhees Feb 16, 2024
2c659a0
remove validateAddress from validatePositionRequest
chasevoorhees Feb 16, 2024
a64d509
Merge branch 'development' into development
nkhrs Feb 19, 2024
ea5bcab
Merge branch 'development' into development
chasevoorhees Feb 27, 2024
1f7009c
Osmosis: Fixed sig fig issues caused by DAI being excessive. Fixed al…
chasevoorhees Feb 28, 2024
bf11643
Merge branch 'development' of https://github.com/pecuniafinance/gatew…
chasevoorhees Feb 28, 2024
d49009a
Osmosis: cleaned some comments, added market price to PoolPriceResponse
chasevoorhees Feb 28, 2024
6a40c38
Osmosis: fix bigint serialization error
chasevoorhees Mar 1, 2024
aa7998e
Osmosis: Updated tokenId to take either positionId or PoolId
chasevoorhees Mar 7, 2024
3db1553
Osmosis: Removed GAAM from poolPositions, fixed interactions with amm…
chasevoorhees Mar 12, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
270 changes: 230 additions & 40 deletions docs/swagger/definitions.yml

Large diffs are not rendered by default.

5 changes: 5 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,11 @@
"test:scripts": "jest -i --verbose ./test-scripts/*.test.ts"
},
"dependencies": {
"@cosmjs/amino": "^0.32.2",
"@bancor/carbon-sdk": "^0.0.93-DEV",
"@cosmjs/proto-signing": "^0.31.1",
"@cosmjs/stargate": "^0.31.1",
"@cosmjs/tendermint-rpc": "^0.32.2",
"@crocswap/sdk": "^2.4.5",
"@ethersproject/abstract-provider": "5.7.0",
"@ethersproject/address": "5.7.0",
Expand All @@ -37,6 +39,7 @@
"@harmony-js/utils": "^0.1.56",
"@improbable-eng/grpc-web": "^0.13.0",
"@injectivelabs/sdk-ts": "^1.10.58",
"@osmonauts/math": "^1.11.3",
"@pancakeswap/sdk": "^4.0.0",
"@pancakeswap/smart-router": "^4.2.1",
"@pancakeswap/swap-sdk-core": "^1.0.0",
Expand Down Expand Up @@ -92,6 +95,8 @@
"minimist": "^1.2.6",
"morgan": "^1.10.0",
"near-api-js": "1.0.0",
"osmo-query": "16.5.2",
"osmojs": "16.5.1",
"promise-retry": "^2.0.1",
"quickswap-sdk": "^3.0.8",
"quipuswap-v3-sdk": "^0.0.7",
Expand Down
49 changes: 41 additions & 8 deletions src/amm/amm.controllers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -86,12 +86,18 @@ import { Algorand } from '../chains/algorand/algorand';
import { Tinyman } from '../connectors/tinyman/tinyman';
import { Plenty } from '../connectors/plenty/plenty';
import { QuipuSwap } from '../connectors/quipuswap/quipuswap';
import { Osmosis } from '../chains/osmosis/osmosis';
import { AMOUNT_NOT_SUPPORTED_ERROR_CODE, ENDPOINT_NOT_SUPPORTED_ERROR_MESSAGE, HttpException } from '../services/error-handler';
import { Carbonamm } from '../connectors/carbon/carbonAMM';

export async function price(req: PriceRequest): Promise<PriceResponse> {
const chain = await getInitializedChain<
Algorand | Ethereumish | Nearish | Tezosish
Algorand | Ethereumish | Nearish | Tezosish | Osmosis
>(req.chain, req.network);
if (chain instanceof Osmosis){
return chain.controller.price(chain as unknown as Osmosis, req);
}

const connector: Uniswapish | RefAMMish | Tinyman | Plenty | QuipuSwap =
await getConnector<Uniswapish | RefAMMish | Tinyman | Plenty | QuipuSwap>(
req.chain,
Expand All @@ -117,8 +123,12 @@ export async function price(req: PriceRequest): Promise<PriceResponse> {

export async function trade(req: TradeRequest): Promise<TradeResponse> {
const chain = await getInitializedChain<
Algorand | Ethereumish | Nearish | Tezosish
Algorand | Ethereumish | Nearish | Tezosish | Osmosis
>(req.chain, req.network);
if (chain instanceof Osmosis){
return chain.controller.trade(chain as unknown as Osmosis, req);
}

const connector: Uniswapish | RefAMMish | Tinyman | Plenty | QuipuSwap =
await getConnector<Uniswapish | RefAMMish | Tinyman | Plenty | QuipuSwap>(
req.chain,
Expand All @@ -145,7 +155,10 @@ export async function trade(req: TradeRequest): Promise<TradeResponse> {
export async function addLiquidity(
req: AddLiquidityRequest
): Promise<AddLiquidityResponse> {
const chain = await getInitializedChain<Ethereumish>(req.chain, req.network);
const chain = await getInitializedChain<Ethereumish | Osmosis>(req.chain, req.network);
if (chain instanceof Osmosis){
return chain.controller.addLiquidity(chain as unknown as Osmosis, req);
}
const connector: UniswapLPish = await getConnector<UniswapLPish>(
req.chain,
req.network,
Expand All @@ -158,7 +171,10 @@ export async function addLiquidity(
export async function reduceLiquidity(
req: RemoveLiquidityRequest
): Promise<RemoveLiquidityResponse> {
const chain = await getInitializedChain<Ethereumish>(req.chain, req.network);
const chain = await getInitializedChain<Ethereumish | Osmosis>(req.chain, req.network);
if (chain instanceof Osmosis){
return chain.controller.removeLiquidity(chain as unknown as Osmosis, req);
}
const connector: UniswapLPish = await getConnector<UniswapLPish>(
req.chain,
req.network,
Expand All @@ -171,7 +187,14 @@ export async function reduceLiquidity(
export async function collectFees(
req: CollectEarnedFeesRequest
): Promise<RemoveLiquidityResponse> {
const chain = await getInitializedChain<Ethereumish>(req.chain, req.network);
const chain = await getInitializedChain<Ethereumish | Osmosis>(req.chain, req.network);
if (chain instanceof Osmosis){
throw new HttpException(
500,
ENDPOINT_NOT_SUPPORTED_ERROR_MESSAGE,
AMOUNT_NOT_SUPPORTED_ERROR_CODE
);
}
const connector: UniswapLPish = await getConnector<UniswapLPish>(
req.chain,
req.network,
Expand All @@ -183,7 +206,10 @@ export async function collectFees(
export async function positionInfo(
req: PositionRequest
): Promise<PositionResponse> {
const chain = await getInitializedChain<Ethereumish>(req.chain, req.network);
const chain = await getInitializedChain<Ethereumish | Osmosis>(req.chain, req.network);
if (chain instanceof Osmosis){
return chain.controller.poolPositions(chain as unknown as Osmosis, req);
}
const connector: UniswapLPish = await getConnector<UniswapLPish>(
req.chain,
req.network,
Expand All @@ -195,7 +221,10 @@ export async function positionInfo(
export async function poolPrice(
req: PoolPriceRequest
): Promise<PoolPriceResponse> {
const chain = await getInitializedChain<Ethereumish>(req.chain, req.network);
const chain = await getInitializedChain<Ethereumish | Osmosis>(req.chain, req.network);
if (chain instanceof Osmosis){
return chain.controller.poolPrice(chain as unknown as Osmosis, req);
}
const connector: UniswapLPish = await getConnector<UniswapLPish>(
req.chain,
req.network,
Expand All @@ -208,8 +237,12 @@ export async function estimateGas(
req: NetworkSelectionRequest
): Promise<EstimateGasResponse> {
const chain = await getInitializedChain<
Algorand | Ethereumish | Nearish | Tezosish
Algorand | Ethereumish | Nearish | Tezosish | Osmosis
>(req.chain, req.network);
if (chain instanceof Osmosis){
return chain.controller.estimateGas(chain as unknown as Osmosis);
}

const connector: Uniswapish | RefAMMish | Tinyman | Plenty | QuipuSwap =
await getConnector<Uniswapish | RefAMMish | Plenty | QuipuSwap>(
req.chain,
Expand Down
72 changes: 45 additions & 27 deletions src/amm/amm.requests.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { CoinAndSymbol, SerializableExtendedPool as CosmosSerializableExtendedPool } from '../chains/osmosis/osmosis.types';
import { PerpPosition } from '../connectors/perp/perp';
import {
NetworkSelectionRequest,
Expand Down Expand Up @@ -29,24 +30,27 @@ export interface PriceResponse {
gasPrice: number;
gasPriceToken: string;
gasLimit: number;
gasCost: string;
gasCost: string; // also gasUsed for Cosmos prices
gasWanted?: string;
}

export interface PoolPriceRequest extends NetworkSelectionRequest {
fengtality marked this conversation as resolved.
Show resolved Hide resolved
token0: string;
token1: string;
fee: string;
period: number;
interval: number;
address?: string
fee?: string;
period?: number;
interval?: number;
}

export interface PoolPriceResponse {
fengtality marked this conversation as resolved.
Show resolved Hide resolved
token0: string;
token1: string;
fee: string;
period: number;
interval: number;
prices: string[];
fee?: string;
period?: number;
interval?: number;
prices?: string[];
pools?: CosmosSerializableExtendedPool[];
network: string;
timestamp: number;
latency: number;
Expand All @@ -71,32 +75,37 @@ export interface TradeResponse {
latency: number;
base: string;
quote: string;
amount: string;
amount: string; // traderequest.amount
finalAmountReceived?: string; // Cosmos
rawAmount: string;
finalAmountReceived_basetoken?: string; // Cosmos
expectedIn?: string;
expectedOut?: string;
price: string;
expectedOut?: string; // Cosmos: expectedAmountReceived
expectedPrice?: string; // Cosmos
price: string; // Cosmos: finalPrice
gasPrice: number;
gasPriceToken: string;
gasLimit: number;
gasCost: string;
gasWanted?: string; // Cosmos
gasCost: string; // Cosmos: gasUsed
nonce?: number;
txHash: string | any | undefined;
}

export interface AddLiquidityRequest extends NetworkSelectionRequest {
export interface AddLiquidityRequest extends NetworkSelectionRequest { // now also cosmos add swap position OR cosmos add LP position
fengtality marked this conversation as resolved.
Show resolved Hide resolved
address: string;
token0: string;
token1: string;
amount0: string;
amount1: string;
fee: string;
lowerPrice: string; // integer as string
upperPrice: string; // integer as string
tokenId?: number;
fee?: string;
lowerPrice?: string; // integer as string // COSMOS - using this != undefined then call addpositionLP(), else: addposition()
upperPrice?: string; // integer as string
tokenId?: number; // COSMOS: poolId - will select one for you if not provided
nonce?: number;
maxFeePerGas?: string;
maxPriorityFeePerGas?: string;
allowedSlippage?: string; // COSMOS: used to calc TokenMinAmount
}

export interface AddLiquidityResponse {
fengtality marked this conversation as resolved.
Show resolved Hide resolved
Expand All @@ -106,42 +115,51 @@ export interface AddLiquidityResponse {
token0: string;
token1: string;
fee: string;
tokenId: number;
gasPrice: number;
tokenId: number; // COSMOS - this is poolId
gasPrice: number | string; // COSMOS: string
gasPriceToken: string;
gasLimit: number;
gasCost: string;
gasCost: string; // gasUsed for Cosmos
gasWanted?: string;
nonce: number;
txHash: string | undefined;
poolAddress?: string; // Cosmos only
poolShares?: string; // Cosmos only
token0FinalAmount?: string; // Cosmos only
token1FinalAmount?: string; // Cosmos only
}

export interface CollectEarnedFeesRequest extends NetworkSelectionRequest {
address: string;
tokenId: number;
tokenId: number; // COSMOS - this is poolId
nonce?: number;
maxFeePerGas?: string;
maxPriorityFeePerGas?: string;
}

export interface RemoveLiquidityRequest extends CollectEarnedFeesRequest {
fengtality marked this conversation as resolved.
Show resolved Hide resolved
decreasePercent?: number;
allowedSlippage?: string;
}

export interface RemoveLiquidityResponse {
fengtality marked this conversation as resolved.
Show resolved Hide resolved
network: string;
timestamp: number;
latency: number;
tokenId: number;
gasPrice: number;
tokenId: number; // COSMOS - this is poolId
gasPrice: number | string; // COSMOS: string
gasPriceToken: string;
gasLimit: number;
gasCost: string;
nonce: number;
gasLimit: number | string;
gasCost: string; // gasUsed for Cosmos
nonce?: number;
txHash: string | undefined;
gasWanted?: string;
balances?: CoinAndSymbol[];
}

export interface PositionRequest extends NetworkSelectionRequest {
tokenId: number;
tokenId?: number; // COSMOS - this is poolId. requried for both
address?: string; // COSMOS only/required (no idea how this works without address for others)
}

export interface PositionResponse extends LPPositionInfo {
Expand Down
20 changes: 16 additions & 4 deletions src/amm/amm.validators.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,16 @@ import {
validateChain,
validateNetwork,
validateNonce,
validateAddress,
validateMaxFeePerGas,
validateMaxPriorityFeePerGas,
isAddress as isEthereumAddress,
invalidAddressError,
} from '../chains/ethereum/ethereum.validators';

import {
isValidCosmosAddress
} from '../chains/cosmos/cosmos.validators';

import { FeeAmount } from '@uniswap/v3-sdk';

export const invalidConnectorError: string =
Expand Down Expand Up @@ -63,6 +68,13 @@ export const validateConnector: Validator = mkValidator(
(val) => typeof val === 'string'
);

// given a request, look for a key called address that is an Ethereum or Cosmos wallet
export const validateAddress: Validator = mkValidator(
'address',
invalidAddressError,
(val) => typeof val === 'string' && (isEthereumAddress(val) || isValidCosmosAddress(val))
);

export const validateQuote: Validator = mkValidator(
'quote',
invalidQuoteError,
Expand Down Expand Up @@ -121,8 +133,7 @@ export const validateFee: Validator = mkValidator(
'fee',
invalidFeeTier,
(val) =>
typeof val === 'string' &&
Object.keys(FeeAmount).includes(val.toUpperCase())
typeof val === 'string' && Object.keys(FeeAmount).includes(val.toUpperCase())
);

export const validateLowerPrice: Validator = mkValidator(
Expand Down Expand Up @@ -181,7 +192,7 @@ export const validateDecreasePercent: Validator = mkValidator(
export const validateAllowedSlippage: Validator = mkValidator(
'allowedSlippage',
invalidAllowedSlippageError,
(val) => typeof val === 'string' && isFractionString(val),
(val) => typeof val === 'string' && (isFractionString(val) || val.includes('%')),
true
);

Expand Down Expand Up @@ -325,6 +336,7 @@ export const validatePositionRequest: RequestValidator = mkRequestValidator([
validateChain,
validateNetwork,
validateTokenId,
validateAddress,
]);

export const validatePoolPriceRequest: RequestValidator = mkRequestValidator([
Expand Down
Loading
Loading