Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add poolId #305

Closed
wants to merge 17 commits into from
Closed

Conversation

vic-en
Copy link
Collaborator

@vic-en vic-en commented Apr 6, 2024

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
Adds PoolId as described in #302
This pr will me merged into Balancer pr to further confirm it works.

Tests performed by the developer:

  • Unit test
  • Curl test to ensure exisiting implementation isn't broken

Tips for QA testing:

  • Perform curl test to ensure existing implemetion isn't broken.

@vic-en vic-en closed this Apr 6, 2024
@vic-en vic-en deleted the feat/add_pool_id branch April 6, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants