Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/uniswap updates #345

Merged
merged 6 commits into from
Aug 15, 2024
Merged

Feat/uniswap updates #345

merged 6 commits into from
Aug 15, 2024

Conversation

fengtality
Copy link
Contributor

A description of the changes proposed in the pull request:

  • Feature branch on top of Feat / Add Uniswap on chains BSC, Avalanche, and Celo #342 that updates the Uniswap libraries to their latest versions
  • I think that this doesn't work with the AlphaRouter used in the current Uniswap connector, so the useRouter: true flag may not work
  • However, this should allow it to be used with useRouter: false across various chains

@fengtality fengtality marked this pull request as ready for review August 13, 2024 01:40
@vic-en vic-en mentioned this pull request Aug 14, 2024
Merged
2 tasks
@fengtality
Copy link
Contributor Author

Merging this PR in so that tests pass again on development

@fengtality fengtality merged commit 212a5c8 into development Aug 15, 2024
5 checks passed
@fengtality fengtality deleted the feat/uniswap-updates branch August 15, 2024 19:01
@nikspz nikspz mentioned this pull request Aug 26, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fengtality @vic-en