Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/remove epoch 8 dex chain #362

Merged
merged 5 commits into from
Sep 24, 2024
Merged

Conversation

fengtality
Copy link
Contributor

@fengtality fengtality commented Sep 24, 2024

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

  • removes near and xrpl chain connectors
  • removes xrpl and dexalot DEX connectors since they are now built into Hummingbot
  • removes ref and perp DEX connectors due to Epoch 8 governance
  • removes PerpAmm, CLOBSpot and CLOBPerp routes and classes

Note that this change removes kujira chain and DEX connectors since it is a CLOB connector, which are only supported in the Hummingbot client.

@fengtality fengtality changed the base branch from main to development September 24, 2024 00:21
@fengtality
Copy link
Contributor Author

failing test shd just be a network issue. it passes locally.

Copy link
Contributor

@rapcmia rapcmia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:

  • gateway commands list and connect does not show any of the removed dex connectors/chain
    • Compare this PR with development branch ok
  • check postman all ok
  • run local make tests getting same error as on github, 09242024.log
    Summary of all failing tests
    FAIL test/services/local-storage.test.ts (13.44 s)
      ● Test local-storage › save, get and delete a key value pair in the local db
    
        AxiosError: Request failed with status code 429
    
          at settle (node_modules/axios/lib/core/settle.js:19:12)
          at IncomingMessage.handleStreamEnd (node_modules/axios/lib/adapters/http.js:585:11)
    
    
    Test Suites: 1 failed, 31 passed, 32 total
    Tests:       1 failed, 348 passed, 349 total
    Snapshots:   0 total
    Time:        202.823 s
    Ran all test suites matching /.\/test\//i.
    Force exiting Jest: Have you considered using `--detectOpenHandles` to detect async operations that kept running after all tests finished?
    

@fengtality fengtality merged commit 5295af9 into development Sep 24, 2024
4 of 5 checks passed
@fengtality fengtality deleted the fix/remove-epoch-8-dex-chain branch September 24, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Release 2.1.0
Development

Successfully merging this pull request may close these issues.

2 participants