-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) naming get_connector_spec fix #6992
(fix) naming get_connector_spec fix #6992
Conversation
From the code in this PR, you are just changing the name of the locally scoped |
updated: @fengtality @nikspz after alitlle digging the iteration must have stopped on avalanche from SUPPORTED_CHAINS set, so its final result must have been Uniswap_avalanche_avalanche, so I figured the reason why chain_name worked instead of chain was there was changes to arrangements in the set SUPPORTED_CHAINS which placed ethereum first on the iteration list Either ways both solutions were buggy I figured another solution on my latest commit |
I think this approach is more simple and solves the problem @nikspz |
Agreed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test performed:
- Cloned and installed PR6992 and gateway latest development
- connected gateway uniswap_ethereum_arbitrum, pangolin_avalanche_avalanche, uniswapLP_ethereum_arbitrum, sushiswap_ethereum_mainnet, sushiswap_avalanche_avalanche, quickswap_polygon_mainnet
- checked balance successfully
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Tests performed by the developer:
while working on hummingbot/gateway#316 noticed
curl tests work fine with balance and allowances
but I get error from the client
ValueError: not enough values to unpack (expected 2, got 1)
Due to naming convention client uses avalanche i.e Network as chain, making the split process not happen leading to a bug
Tips for QA testing: