Ensure discoverability of orphaned enumeration objects

hunyadi · Jan 31, 2024 · dcb707e · dcb707e
1 parent ca0ae5a
commit dcb707e
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/pysqlsync/dialect/oracle/discovery.py b/pysqlsync/dialect/oracle/discovery.py
@@ -232,8 +232,6 @@ async def _get_namespace(self, namespace_id: Optional[LocalId] = None) -> Namesp
             tables.append(table)
 
         if tables:
-            return self.factory.namespace_class(
-                LocalId(""), enums=[], structs=[], tables=tables
-            )
+            return self.factory.namespace_class(enums=[], structs=[], tables=tables)
         else:
             return self.factory.namespace_class()
diff --git a/pysqlsync/dialect/postgresql/discovery.py b/pysqlsync/dialect/postgresql/discovery.py
@@ -392,7 +392,7 @@ async def get_namespace(self, namespace_id: LocalId) -> Namespace:
             table = await self.get_table(QualifiedId(namespace_id.id, table_name))
             tables.append(table)
 
-        if tables:
+        if enums or structs or tables:
             return self.factory.namespace_class(
                 namespace_id, enums=enums, structs=structs, tables=tables
             )

diff --git a/pysqlsync/formation/object_types.py b/pysqlsync/formation/object_types.py
@@ -534,6 +534,16 @@ def __init__(self) -> None:
     def __init__(self, name: LocalId) -> None:
         ...
 
+    @overload
+    def __init__(
+        self,
+        *,
+        enums: list[EnumType],
+        structs: list[StructType],
+        tables: list[Table],
+    ) -> None:
+        ...
+
     @overload
     def __init__(
         self,