Skip to content

Commit

Permalink
Only sync files when they're changed locally/remotely (#164)
Browse files Browse the repository at this point in the history
Previously we'd be syncing files in an endless loop, which wasn't great from a UI/UX perspective. This new implementation checks the local and remote files against those recorded since the last sync, and uses those to figure out if a directory sync needs to be done.

Currently we sync the entire directory pair when a change is detected, but this is still a fair amount better than the implementation we had previously. We'll fine-tune out the implementation at a later time.
  • Loading branch information
hwittenborn authored Oct 23, 2023
1 parent bd3e6ef commit 1b94fea
Show file tree
Hide file tree
Showing 8 changed files with 241 additions and 42 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [0.8.0] - 2023-10-23
### Changed
- Added functionality to only run sync checks when files are changed.

## [0.7.0] - 2023-10-07
### Changed
- Remove reliance on GTK3 and libappindicator.
Expand Down
2 changes: 1 addition & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "celeste"
version = "0.7.0"
version = "0.8.0"
edition = "2021"

[dependencies]
Expand Down
12 changes: 12 additions & 0 deletions assets/com.hunterwittenborn.Celeste.metainfo.xml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,18 @@
</screenshot>
</screenshots>
<releases>
<release date="2023-10-23" version="0.8.0">
<description>
<p>
Changes in this release:
</p>
<ul>
<li>
Added functionality to only run sync checks when files are changed.
</li>
</ul>
</description>
</release>
<release date="2023-10-07" version="0.7.0">
<description>
<p>
Expand Down
2 changes: 1 addition & 1 deletion makedeb/PKGBUILD
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Maintainer: Hunter Wittenborn <hunter@hunterwittenborn.com>
pkgname=celeste
pkgver=0.7.0
pkgver=0.8.0
pkgrel=1
pkgdesc='Sync your cloud files'
arch=('any')
Expand Down
61 changes: 30 additions & 31 deletions po/com.hunterwittenborn.Celeste.pot
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
#, fuzzy
msgid ""
msgstr ""
"Project-Id-Version: Celeste 0.7.0\n"
"Project-Id-Version: Celeste 0.8.0\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2023-10-08 00:55+0000\n"
"POT-Creation-Date: 2023-10-23 20:35+0000\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language-Team: LANGUAGE <LL@li.org>\n"
Expand Down Expand Up @@ -120,97 +120,96 @@ msgstr ""
msgid "All the directories associated with this remote will also stop syncing."
msgstr ""

#. Notify the tray app that we're syncing this remote now.
#: src/launch.rs:1160
#: src/launch.rs:1342 src/launch.rs:2509
msgid "Files are synced."
msgstr ""

#: src/launch.rs:1352
msgid "Syncing '{}'..."
msgstr ""

#: src/launch.rs:1194
#: src/launch.rs:1373
msgid "Checking for changes..."
msgstr ""

#. Add an error for reporting in the UI.
#: src/launch.rs:1201
#: src/launch.rs:1380
msgid "Please resolve the reported syncing issues."
msgstr ""

#: src/launch.rs:1228
#: src/launch.rs:1407
msgid "{} errors found. "
msgstr ""

#: src/launch.rs:1242
#: src/launch.rs:1421
msgid "Would you like to dismiss this error?"
msgstr ""

#: src/launch.rs:1269
#: src/launch.rs:1448
msgid "Failed to sync '{}' to '{}' on remote."
msgstr ""

#: src/launch.rs:1277
#: src/launch.rs:1456
msgid "Failed to sync '{}' on remote to '{}'."
msgstr ""

#: src/launch.rs:1302
#: src/launch.rs:1481
msgid "Unable to fetch data for '{}' from the remote."
msgstr ""

#: src/launch.rs:1311 src/launch.rs:1316 src/launch.rs:1324
#: src/launch.rs:1490 src/launch.rs:1495 src/launch.rs:1503
msgid "File Update"
msgstr ""

#: src/launch.rs:1311
#: src/launch.rs:1490
msgid "Neither the local item or remote item exists anymore. This error will now be removed."
msgstr ""

#: src/launch.rs:1316
#: src/launch.rs:1495
msgid "Only the local item exists now, so it will be synced to the remote."
msgstr ""

#: src/launch.rs:1324
#: src/launch.rs:1503
msgid "Only the remote item exists now, so it will be synced to the local machine."
msgstr ""

#: src/launch.rs:1334
#: src/launch.rs:1513
msgid "Both the local item '{}' and remote item '{}' have been updated since the last sync."
msgstr ""

#: src/launch.rs:1336
#: src/launch.rs:1515
msgid "Which item would you like to keep?"
msgstr ""

#: src/launch.rs:1338
#: src/launch.rs:1517
msgid "Local"
msgstr ""

#: src/launch.rs:1339
#: src/launch.rs:1518
msgid "Remote"
msgstr ""

#: src/launch.rs:1388
#: src/launch.rs:1567
msgid "1 error found."
msgstr ""

#: src/launch.rs:1390
#: src/launch.rs:1569
msgid "{} errors found."
msgstr ""

#: src/launch.rs:1522
#: src/launch.rs:1701
msgid "Checking '{}' for changes..."
msgstr ""

#: src/launch.rs:1938
#: src/launch.rs:2117
msgid "Checking '{}' on remote for changes..."
msgstr ""

#: src/launch.rs:2329
msgid "Directory has finished sync checks."
msgstr ""

#: src/launch.rs:2350
#: src/launch.rs:2530
msgid "Finished sync checks with {} errors."
msgstr ""

#: src/launch.rs:2355
#: src/launch.rs:2535
msgid "Finished sync checks."
msgstr ""

Expand Down Expand Up @@ -318,11 +317,11 @@ msgstr ""
msgid "Awaiting sync checks..."
msgstr ""

#: src/tray.rs:57
#: src/tray.rs:60
msgid "Open"
msgstr ""

#: src/tray.rs:64
#: src/tray.rs:67
msgid "Close"
msgstr ""

Expand Down
Loading

0 comments on commit 1b94fea

Please sign in to comment.