Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support setting extended client options #889

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

hotraygroup
Copy link

support setting extended client options via callback

@gen2thomas
Copy link
Collaborator

Hi @hotraygroup thanks for adjustments. Some comments:

  • please add a small unit test for the new functionality, at least for "Connect()"
  • is there the possibility to show the usage of the new functionality in an example?

For the example: There are 3 at the moment. Either you can add to one of them or write a new one.

@gen2thomas gen2thomas deleted the branch hybridgroup:dev May 15, 2023 16:25
@gen2thomas gen2thomas closed this May 15, 2023
@gen2thomas
Copy link
Collaborator

accidentally closed - now reopen

@gen2thomas gen2thomas reopened this May 23, 2023
@gen2thomas
Copy link
Collaborator

Hi @hotraygroup , I'm going to set this PR back to draft since there is no progress yet. Feel free to fix the remarks and set it back to active.

@gen2thomas gen2thomas marked this pull request as draft October 10, 2023 17:55
@gen2thomas gen2thomas requested review from gen2thomas and removed request for gen2thomas October 10, 2023 17:55
@gen2thomas gen2thomas self-assigned this Oct 10, 2023
@hotraygroup hotraygroup force-pushed the release branch 2 times, most recently from f352e12 to ed0c79a Compare March 27, 2024 11:57
…mqttAdaptor := mqtt.NewAdaptorWithAuth(...); mqttAdaptor.SetOptionsFn(func(opts *paho.ClientOptions) {opts.WillPayload = []byte("goodbye")
@hotraygroup
Copy link
Author

usage:
mqttAdaptor := mqtt.NewAdaptorWithAuth(...)
mqttAdaptor.SetOptionsFn(func(opts *paho.ClientOptions) {opts.WillPayload = []byte("goodbye")})

@gen2thomas gen2thomas added the maintainer wanted the implementation was started, but for some reason not finished label Nov 1, 2024
@gen2thomas gen2thomas removed their assignment Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer wanted the implementation was started, but for some reason not finished
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants