Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less computation on notebooks #211

Merged
merged 5 commits into from
Oct 15, 2024
Merged

Less computation on notebooks #211

merged 5 commits into from
Oct 15, 2024

Conversation

RondeauG
Copy link
Collaborator

@RondeauG RondeauG commented Oct 9, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Reduces the computation needed by the notebooks. Notably:
    • The modelling notebook now gets its data from xhydro-testdata instead of using xdatasets/planetary-computer.
    • The local frequency analysis notebook is done on 2 stations instead of 5.
    • The regional analysis notebook is done on 15 stations instead of 25. Only annual maximums are used.
    • The uncertainty analysis is done using 35 bootstraps instead of 200.

Does this PR introduce a breaking change?

Other information:

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@RondeauG RondeauG changed the title less computation Less computation on notebooks Oct 9, 2024
@RondeauG RondeauG requested a review from TC-FF October 9, 2024 20:21
@github-actions github-actions bot added notebooks Run tests against notebooks docs labels Oct 9, 2024
@RondeauG
Copy link
Collaborator Author

@sebastienlanglois Aurais-tu une idée de ce qui plante actuellement dans le module gis? Tout passait correctement il y a trois jours (e.g. #209) et je vois très peu de changements dans les environnements. J'ai fait quelques tests localement, mais je ne trouve pas...

@sebastienlanglois
Copy link
Contributor

Oui, il semble que le Planetary Computer ont bloqué l'accès à leur stockage via http depuis hier. Il existe un fix où il faut demander un SAS token afin que l'url soit sécurisé, mais a priori avec cette approche, ça devrait réparer le module. Je vais implémenter un fix d'ici demain et pousser une PR.

@Zeitsperre
Copy link
Collaborator

@sebastienlanglois If we want to add a token to the repository secrets as an environment variable, this can be easily done for both GitHub and ReadTheDocs. Contact me if you're interested in that approach.

@sebastienlanglois
Copy link
Contributor

@Zeitsperre @RondeauG I have implemented the fix for the GIS module here : #213

# Conflicts:
#	docs/notebooks/hydrological_modelling.ipynb
Copy link
Collaborator

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but wait for @sebastienlanglois's approval

@github-actions github-actions bot added the approved Approved for additional tests label Oct 11, 2024
Copy link
Contributor

@sebastienlanglois sebastienlanglois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/notebooks/hydrological_modelling.ipynb Show resolved Hide resolved
@RondeauG RondeauG merged commit 9e18401 into main Oct 15, 2024
24 checks passed
@RondeauG RondeauG deleted the simplify_notebooks branch October 15, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests docs notebooks Run tests against notebooks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants