-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Less computation on notebooks #211
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@sebastienlanglois Aurais-tu une idée de ce qui plante actuellement dans le module |
Oui, il semble que le Planetary Computer ont bloqué l'accès à leur stockage via http depuis hier. Il existe un fix où il faut demander un SAS token afin que l'url soit sécurisé, mais a priori avec cette approche, ça devrait réparer le module. Je vais implémenter un fix d'ici demain et pousser une PR. |
@sebastienlanglois If we want to add a token to the repository secrets as an environment variable, this can be easily done for both GitHub and ReadTheDocs. Contact me if you're interested in that approach. |
@Zeitsperre @RondeauG I have implemented the fix for the GIS module here : #213 |
# Conflicts: # docs/notebooks/hydrological_modelling.ipynb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but wait for @sebastienlanglois's approval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request Checklist:
number
) and pull request (:pull:number
) has been added.What kind of change does this PR introduce?
xhydro-testdata
instead of usingxdatasets/planetary-computer
.Does this PR introduce a breaking change?
Other information: