Improved the _ravenpy_models.py script to be able to specify the rain snow fraction for all models #215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number
) and pull request (:pull:number
) has been added.What kind of change does this PR introduce?
Improved the _ravenpy_models.py script to be able to specify the rain snow fraction for all models, including HBVEC. With the new version of RavenPy (v0.16.0, unreleased), the rain_snow_fraction could be set with "RainSnowFraction=rain_snow_fraction" in the self.default_emulator_config dictionary. See: CSHS-CWRA/RavenPy#408. For now (based on the latest release RavenPy version, v0.15.0) the change I'm suggesting here will enable changing the rain snow fraction algorithm for HBVEC as well.
Does this PR introduce a breaking change?
None foreseen.
Other information: