Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a periods argument to local.fit #219

Merged
merged 6 commits into from
Oct 28, 2024
Merged

Add a periods argument to local.fit #219

merged 6 commits into from
Oct 28, 2024

Conversation

RondeauG
Copy link
Collaborator

@RondeauG RondeauG commented Oct 25, 2024 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Add a periods argument to local.fit, to compute multiple separate periods with a single call. Both periods and horizon follow xscen conventions.

Does this PR introduce a breaking change?

  • No. When periods=None, the function acts as before.

Other information:

@RondeauG RondeauG requested a review from TC-FF October 25, 2024 19:54
TC-FF
TC-FF approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@TC-FF TC-FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parfait, avec la légère modification discuté de toujours laisser "horizon" en coordonnée

@github-actions github-actions bot added the approved Approved for additional tests label Oct 28, 2024
@RondeauG RondeauG merged commit 21c0025 into main Oct 28, 2024
17 checks passed
@RondeauG RondeauG deleted the fit_periods branch October 28, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TC-FF TC-FF TC-FF approved these changes

Assignees
No one assigned
Labels
approved Approved for additional tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RondeauG @TC-FF