Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support latest xclim and xscen, drop outdated pins #228

Merged
merged 9 commits into from
Nov 7, 2024
Merged

Support latest xclim and xscen, drop outdated pins #228

merged 9 commits into from
Nov 7, 2024

Conversation

RondeauG
Copy link
Collaborator

@RondeauG RondeauG commented Nov 7, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Updates the environment to support the latest xclim/xscen.
  • Removes pins to:
    • pydantic: The issue seems to have been resolved.
    • s3fs: Tests are passing without the pin, so I don't that it's fine now? We should maybe reverse the pin (e.g. >2024.10.0)?
  • Added an option in publish_release_notes to only print the ntes relevant to the latest release.

Does this PR introduce a breaking change?

  • xHydro now requires the latest version of xclim/xscen.

Other information:

Copy link
Collaborator

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest keeping some of the lower pins, just those based on https://scientific-python.org/specs/spec-0000/. It helps guide maintainer on what versions we should be supporting and when we can safely drop older ones.

environment-dev.yml Show resolved Hide resolved
environment-dev.yml Show resolved Hide resolved
environment.yml Show resolved Hide resolved
environment.yml Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/conftest.py Show resolved Hide resolved
src/xhydro/testing/utils.py Show resolved Hide resolved
@github-actions github-actions bot added the approved Approved for additional tests label Nov 7, 2024
tests/conftest.py Outdated Show resolved Hide resolved
Co-authored-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
tests/conftest.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
@RondeauG RondeauG merged commit 85931e6 into main Nov 7, 2024
17 checks passed
@RondeauG RondeauG deleted the pre041 branch November 7, 2024 18:03
@sebastienlanglois
Copy link
Contributor

@RondeauG @Zeitsperre Do we always want to support the latest xclim/xscen pins or is this PR just a one off ? In the current case, xclim is not compatible with the new xarray==2024.10.0 but we were already using it for the Zarr v3 compatibility and DataTree component now available.

These conflicts are rare but maybe we could keep a few pins back to allow more flexibility in case they happen.

@RondeauG
Copy link
Collaborator Author

RondeauG commented Nov 8, 2024

It should not happen too often. Specifically here, there were many recent changes in xclim and xclim-testdata that were difficult to support retroactively both in xscen and xHydro, so it was simpler that way.

That being said, we could decide on a number of versions or a length of time (e.g. 6 months or 1 year) that we always want to support no matter what.

@Zeitsperre
Copy link
Collaborator

@sebastienlanglois Like Gabriel says, there were some major changes in the testing data handling.

I've been trying to base some decisions for minimum supported versions on the SciPy SPEC-0 suggestions, but we can choose any other timeline for deprecations.

One note about xarray, we will be supporting the next release; There was a regression introduced in 2024.10.0 that impacted some functions. The fix is already on their development branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants