-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support latest xclim and xscen, drop outdated pins #228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest keeping some of the lower pins, just those based on https://scientific-python.org/specs/spec-0000/. It helps guide maintainer on what versions we should be supporting and when we can safely drop older ones.
Co-authored-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
@RondeauG @Zeitsperre Do we always want to support the latest xclim/xscen pins or is this PR just a one off ? In the current case, These conflicts are rare but maybe we could keep a few pins back to allow more flexibility in case they happen. |
It should not happen too often. Specifically here, there were many recent changes in That being said, we could decide on a number of versions or a length of time (e.g. 6 months or 1 year) that we always want to support no matter what. |
@sebastienlanglois Like Gabriel says, there were some major changes in the testing data handling. I've been trying to base some decisions for minimum supported versions on the SciPy SPEC-0 suggestions, but we can choose any other timeline for deprecations. One note about |
Pull Request Checklist:
number
) and pull request (:pull:number
) has been added.What kind of change does this PR introduce?
pydantic
: The issue seems to have been resolved.s3fs
: Tests are passing without the pin, so I don't that it's fine now? We should maybe reverse the pin (e.g.>2024.10.0
)?publish_release_notes
to only print the ntes relevant to the latest release.Does this PR introduce a breaking change?
Other information: