Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small typing fixes #47

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Small typing fixes #47

merged 2 commits into from
Nov 7, 2023

Conversation

RondeauG
Copy link
Collaborator

@RondeauG RondeauG commented Nov 7, 2023 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • No.
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • HISTORY.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Fix a few typing issues, including the lack of Optional.
  • Remove scipy as a dependency, since changes in Better detection of fit params #43 removed the need to explicitly call it.

Does this PR introduce a breaking change?

  • No.

Other information:

@RondeauG RondeauG requested a review from Zeitsperre November 7, 2023 21:02
@RondeauG RondeauG merged commit 01d5930 into main Nov 7, 2023
12 checks passed
@RondeauG RondeauG deleted the typing branch November 7, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeitsperre Zeitsperre Zeitsperre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RondeauG @Zeitsperre