move to npm packages again #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
platypii
approved these changes
Dec 13, 2024
|
OK, all good now. Let's try. |
platypii
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the current setup works well!
It uses npm workspaces and allows the development of several packages at the same time (eg. components and hyperparam). The only drawback is that we still have to build components (
npm run build -w @hyparam/components) after a change. But no more need to publish to npm, or change the version (we can decorrelate version publishing from changes).We can also merge components back to hyperparam (#119) if we want to (maybe let's try this way first), but the workspaces can still be useful for the two demo apps.