Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unversion built artifacts #135

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Unversion built artifacts #135

merged 3 commits into from
Dec 18, 2024

Conversation

severo
Copy link
Contributor

@severo severo commented Dec 18, 2024

fixes #64

Remove the need to manually build the artifacts for the hyperparam cli.

The build step is now run before installing, packing, publishing or running the app (from the code).

The artifacts are no more versioned.

@severo severo requested a review from platypii December 18, 2024 16:11
@severo severo marked this pull request as draft December 18, 2024 16:12
@severo severo removed the request for review from platypii December 18, 2024 16:12
@severo
Copy link
Contributor Author

severo commented Dec 18, 2024

Explication for the CI failure: npm/cli#4139 (comment)

The order of workspaces in the root package.json is not respected when it comes to "npm run prepare"... What a shame.

@severo severo requested a review from platypii December 18, 2024 16:34
@severo severo marked this pull request as ready for review December 18, 2024 16:34
@severo severo force-pushed the 64-unversion-built-artifacts branch from c865743 to 68b0c6d Compare December 18, 2024 22:40
@severo severo merged commit 2ab1e48 into master Dec 18, 2024
6 checks passed
@severo severo deleted the 64-unversion-built-artifacts branch December 18, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cli] unversion public/build/app.min.js (and .map)
2 participants