better on_ground calc

[andrewgazelka]

right now is on_ground: velocity.velocity == Vec3::ZERO,

[linear]

HYP-116 better on_ground calc

[andrewgazelka]

closing cause backlog

[Tebarem]

i added one on the physics branch its 100% accurate

[andrewgazelka]

ok re-opening so you can close it @Tebarem on merge

[Tebarem]

#696

[andrewgazelka]

nooooo

[andrewgazelka]

like this

[andrewgazelka]

now when your PR is merged it will auto close this issue

[Tebarem]

bruh. why did i not know of this

[andrewgazelka]

this is not actually truly correct. should look at AABB collisions similar to try_change_position probably

[Tebarem]

@andrewgazelka how come? can u show a clip

[andrewgazelka]

A good example would be a half slab. If there is a half slab below the player, your algorithm would think that the player is on the ground when there's still a half block of air to go. So you need to actually look at the bounding boxes of the block to determine if the player is on the ground.

[Tebarem]

you are right i didnt account for that. will have a look again