Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): physics #696

Merged
merged 24 commits into from
Dec 13, 2024
Merged

feat(core): physics #696

merged 24 commits into from
Dec 13, 2024

Conversation

Tebarem
Copy link
Collaborator

@Tebarem Tebarem commented Dec 10, 2024 •
edited by andrewgazelka
Loading

@github-actions github-actions bot added the feat label Dec 10, 2024
@andrewgazelka andrewgazelka marked this pull request as draft December 10, 2024 21:54
@andrewgazelka andrewgazelka changed the title feat: Physics(WIP) feat(hyperion): physics Dec 10, 2024
@andrewgazelka andrewgazelka changed the title feat(hyperion): physics feat(core): physics Dec 10, 2024
@Tebarem Tebarem mentioned this pull request Dec 11, 2024
Open
@Tebarem
Copy link
Collaborator Author

Tebarem commented Dec 12, 2024

So player sync is working Just not pose couldnt figure that one out. For some reason when a 2nd player is in the server the bow doesnt work. I think its to do with BowCharging Component.

Also The arrows are so jittery. Not sure how to fix.

@andrewgazelka
Copy link
Collaborator

So player sync is working Just not pose couldnt figure that one out. For some reason when a 2nd player is in the server the bow doesnt work. I think its to do with BowCharging Component.

Also The arrows are so jittery. Not sure how to fix.

i'd say things don't have to be perfect. can always do things in multiple PRs

This was referenced Dec 13, 2024
Closed
Closed
@Tebarem Tebarem linked an issue Dec 13, 2024 that may be closed by this pull request
Sync Armor to other player's clients #614
Closed
This was linked to issues Dec 13, 2024
fix arrow velocity/yaw/pitch (again?) #674
Closed
Players Not in Sync/Updating #676
Closed
@Kumpelinus
Copy link
Collaborator

Some things are still a bit odd but they weren't properly implemented before. It is probably best to handle those in another PR so this one does not get to complicated.

@Kumpelinus Kumpelinus marked this pull request as ready for review December 13, 2024 17:01
@Kumpelinus
Copy link
Collaborator

Looks good to me.

@Kumpelinus
Copy link
Collaborator

@andrewgazelka wanna take a look?

@andrewgazelka
Copy link
Collaborator

@andrewgazelka wanna take a look?

Yes I am right now :)

andrewgazelka
andrewgazelka requested changes Dec 13, 2024
View reviewed changes
crates/hyperion/src/egress/sync_entity_state.rs Outdated Show resolved Hide resolved
crates/hyperion/src/egress/sync_entity_state.rs Outdated Show resolved Hide resolved
crates/hyperion/src/simulation/handlers.rs Show resolved Hide resolved
crates/hyperion/src/simulation/metadata/mod.rs Outdated Show resolved Hide resolved
events/tag/src/command/spawn.rs Show resolved Hide resolved
events/tag/src/module/attack.rs Outdated Show resolved Hide resolved
events/tag/src/module/run/config.toml Outdated Show resolved Hide resolved
events/tag/src/module/bow.rs Show resolved Hide resolved
crates/hyperion/src/simulation/handlers.rs Outdated Show resolved Hide resolved
Kumpelinus and others added 2 commits December 13, 2024 18:28
@Kumpelinus @andrewgazelka
Use Velocity::ZERO
48c5c76 
Co-authored-by: Andrew Gazelka <andrew.gazelka@gmail.com>
@Kumpelinus
Implement comments
03187a0
@andrewgazelka andrewgazelka self-requested a review December 13, 2024 17:43
andrewgazelka
andrewgazelka approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@andrewgazelka andrewgazelka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving after fixes are made and are tested

events/tag/src/module/run/config.toml Outdated Show resolved Hide resolved
events/tag/src/module/bow.rs Show resolved Hide resolved
events/tag/src/command/spawn.rs Show resolved Hide resolved
@Kumpelinus Kumpelinus mentioned this pull request Dec 13, 2024
Closed
@andrewgazelka andrewgazelka merged commit be235e7 into hyperion-mc:main Dec 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kumpelinus Kumpelinus Kumpelinus left review comments

@andrewgazelka andrewgazelka andrewgazelka approved these changes

Assignees
No one assigned
Labels
feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Players Not in Sync/Updating fix arrow velocity/yaw/pitch (again?) Sync Armor to other player's clients
3 participants
@Tebarem @andrewgazelka @Kumpelinus