feat: plugin channel API #760
Closed
+140
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
andrewgazelka
commented
Dec 19, 2024
•
andrewgazelka
commented
- related bot testing infra #759
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+43
to
+51
| .each_iter(|it, _, (queue, registry)| { | ||
| for PluginMessage { channel, data } in queue.drain() { | ||
| let Some(handler) = registry.registry.get(channel) else { | ||
| continue; | ||
| }; | ||
|
|
||
| handler(todo!(), data); | ||
| } | ||
| }); |
There was a problem hiding this comment.
The todo!() macro in the handler call will cause a runtime panic. The system needs to construct and pass a valid PacketSwitchQuery to the handler function. Consider modifying the system signature to include the necessary components for building a PacketSwitchQuery, then pass that to the handler instead of todo!().
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
andrewgazelka
force-pushed
the
andrew/plugin-channel-module
branch
from
16d7375 to
a7b22eb
Compare
|
duplicate #771 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.