Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid parsing documents multiple times #32

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Conversation

jdesrosiers
Copy link
Collaborator

Resolves #30

Parsing TextDocuments into JsoncInstance instances is necessary for most language server features. The more features we add, the more times we will be parsing documents. Centralizing this functionality allows us to cache the result when possible, but also allows us to reduce some code duplication.

From now on, all code should use the getSchemaResources function instead of calling JsoncInstance.fromTextDocument.

@jdesrosiers jdesrosiers merged commit 74297e0 into main Mar 20, 2024
2 checks passed
@jdesrosiers jdesrosiers deleted the managed-instances branch March 20, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server - Avoid reparsing documents for every feature
1 participant