refactor: remove unused MultiProtocolSigner from warp init command & …

…fix missing break statement in HyperlaneIsmFactory switch case
hyperlane-xyz · Dec 11, 2024 · d08966c · d08966c
1 parent ba08190
commit d08966c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/typescript/cli/src/commands/warp.ts b/typescript/cli/src/commands/warp.ts
@@ -8,7 +8,6 @@ import {
   createWarpRouteDeployConfig,
   readWarpRouteDeployConfig,
 } from '../config/warp.js';
-import { MultiProtocolSignerManager } from '../context/strategies/signer/MultiProtocolSignerManager.js';
 import {
   CommandModuleWithContext,
   CommandModuleWithWriteContext,
@@ -155,7 +154,6 @@ export const deploy: CommandModuleWithWriteContext<{
 export const init: CommandModuleWithContext<{
   advanced: boolean;
   out: string;
-  multiProtocolSigner?: MultiProtocolSignerManager;
 }> = {
   command: 'init',
   describe: 'Create a warp route configuration.',
@@ -167,14 +165,13 @@ export const init: CommandModuleWithContext<{
     },
     out: outputFileCommandOption(DEFAULT_WARP_ROUTE_DEPLOYMENT_CONFIG_PATH),
   },
-  handler: async ({ context, advanced, out, multiProtocolSigner }) => {
+  handler: async ({ context, advanced, out }) => {
     logCommandHeader('Hyperlane Warp Configure');
 
     await createWarpRouteDeployConfig({
       context,
       outPath: out,
       advanced,
-      multiProtocolSigner,
     });
     process.exit(0);
   },

diff --git a/typescript/cli/src/config/warp.ts b/typescript/cli/src/config/warp.ts
@@ -21,7 +21,6 @@ import {
   promiseObjAll,
 } from '@hyperlane-xyz/utils';
 
-import { MultiProtocolSignerManager } from '../context/strategies/signer/MultiProtocolSignerManager.js';
 import { CommandContext } from '../context/types.js';
 import { errorRed, log, logBlue, logGreen } from '../logger.js';
 import { runMultiChainSelectionStep } from '../utils/chains.js';
@@ -116,12 +115,10 @@ export async function createWarpRouteDeployConfig({
   context,
   outPath,
   advanced = false,
-  multiProtocolSigner,
 }: {
   context: CommandContext;
   outPath: string;
   advanced: boolean;
-  multiProtocolSigner?: MultiProtocolSignerManager;
 }) {
   logBlue('Creating a new warp route deployment config...');
 

diff --git a/typescript/sdk/src/ism/HyperlaneIsmFactory.ts b/typescript/sdk/src/ism/HyperlaneIsmFactory.ts
@@ -237,10 +237,11 @@ export class HyperlaneIsmFactory extends HyperlaneApp<ProxyFactoryFactories> {
           this.deployer,
           `HyperlaneDeployer must be set to deploy ${ismType}`,
         );
-        return this.deployStorageMultisigIsm({
+        contract = await this.deployStorageMultisigIsm({
           destination,
           config,
         });
+        break;
       default:
         throw new Error(`Unsupported ISM type ${ismType}`);
     }