Fix lag issue with Mailbox message sequence_and_tip #2879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etwork/abacus-monorepo into trevor/fix-lag
daniel-savu
approved these changes
Oct 31, 2023
Comment on lines
-140
to
-144
| let mut client = WasmQueryClient::connect(self.get_conn_url()?).await?; | ||
|
|
||
| let mut request = tonic::Request::new(QuerySmartContractStateRequest { | ||
| address: self.get_contract_addr()?, | ||
| query_data: serde_json::to_string(&payload)?.as_bytes().to_vec(), |
| @@ -280,37 +282,6 @@ impl CosmosMailboxIndexer { | |||
| None | |||
| } | |||
| } | |||
|
|
|||
| #[instrument(level = "debug", err, ret, skip(self))] | |||
| async fn count(&self, lag: Option<NonZeroU64>) -> ChainResult<u32> { | |||
There was a problem hiding this comment.
were these not used at all?
tkporter
merged commit 3cf1d56
into
trevor/new-featv3-cosmos-oct-28
2 of 4 checks passed
yorhodes
pushed a commit
that referenced
this pull request
Nov 2, 2023
### Description
The old implementation of the `sequence_and_tip` fn in mailbox.rs used
to look like this, where it'd end up passing the tip as the lag!
```
let sequence = match NonZeroU64::new(tip as u64) {
None => None,
Some(n) => Some(self.nonce(Some(n)).await?),
};
```
Shuffled things around where we correctly just specify the `tip` as the
block number instead of a lag. This means that all functions that were
calling `wasm_query` with the lag needed to start getting the lagged
block num instead
Sometimes I believe this would create a bug where we'd ask for a block
height 1 and get back RPC errors. I believe most of the time we'd ask
for a block height of 0, in which case it'd just act like we were asking
for the tip
### Drive-by changes
n/a
### Related issues
n/a
### Backward compatibility
n/a
### Testing
plan to roll it out once I get an image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The old implementation of the
sequence_and_tipfn in mailbox.rs used to look like this, where it'd end up passing the tip as the lag!Shuffled things around where we correctly just specify the
tipas the block number instead of a lag. This means that all functions that were callingwasm_querywith the lag needed to start getting the lagged block num insteadSometimes I believe this would create a bug where we'd ask for a block height 1 and get back RPC errors. I believe most of the time we'd ask for a block height of 0, in which case it'd just act like we were asking for the tip
Drive-by changes
n/a
Related issues
n/a
Backward compatibility
n/a
Testing
plan to roll it out once I get an image