-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Index merkle tree insertions just like messages #2886
Merged
tkporter
merged 15 commits into
trevor/new-featv3-cosmos-oct-28
from
trevor/merkle-indexing-as-message
Nov 3, 2023
Merged
Index merkle tree insertions just like messages #2886
tkporter
merged 15 commits into
trevor/new-featv3-cosmos-oct-28
from
trevor/merkle-indexing-as-message
Nov 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rStore, just have it retrieve itself
daniel-savu
approved these changes
Nov 2, 2023
tkporter
merged commit Nov 3, 2023
b926434
into
trevor/new-featv3-cosmos-oct-28
2 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves merkle tree hook insertion indexing away from the watermarked contract sync to the same method that message indexing uses
Drive-by changes
Minor idiomatic changes
Related issues
n/a
Backward compatibility
I believe this is fully backward compatible
Testing
Tested locally by running a relayer with an empty data dir & with an existing data dir. Also tested a validator locally