Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index merkle tree insertions just like messages #2886

Merged

Conversation

tkporter
Copy link
Collaborator

@tkporter tkporter commented Nov 2, 2023

Description

Moves merkle tree hook insertion indexing away from the watermarked contract sync to the same method that message indexing uses

  • Generalizes all the MessageContractSync / MessageSyncCursor etc to work with any "sequenced" data. Sequenced data means a data type that has a sequence # that increases 1 at a time as it's created. E.g. a message's nonce is its sequence, or a merkle tree insertion's leaf index is its sequence

Drive-by changes

Minor idiomatic changes

Related issues

n/a

Backward compatibility

I believe this is fully backward compatible

Testing

Tested locally by running a relayer with an empty data dir & with an existing data dir. Also tested a validator locally

@tkporter tkporter requested a review from daniel-savu as a code owner November 2, 2023 17:12
@tkporter tkporter merged commit b926434 into trevor/new-featv3-cosmos-oct-28 Nov 3, 2023
2 of 4 checks passed
@tkporter tkporter deleted the trevor/merkle-indexing-as-message branch November 3, 2023 10:13
@nambrot nambrot restored the trevor/merkle-indexing-as-message branch November 8, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants