-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hyperlane #2906
hyperlane #2906
Conversation
tendermint-rpc = { version = "0.32.0", features = ["http-client", "tokio"]} | ||
hpl-interface = "0.0.6-rc5" | ||
tendermint-rpc = { version = "0.32.0", features = ["http-client", "tokio"] } | ||
hpl-interface = "=0.0.6-rc3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how come this is using rc3
but run-locally uses rc6
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a hacky approach to make runnable with this - the reason of doing like this is i realized payload in rc6 is not up to date with rc6 contract binary, so i published new version in empty slot temporarily.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, I'll merge it like this but let's open a follow-up PR to address when it's fixed
@@ -53,16 +53,26 @@ pub fn deploy_cw_hyperlane( | |||
); | |||
|
|||
// deploy igp set | |||
#[cw_serde] | |||
pub struct Something { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this should be named InstantiateMsg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, exactly. It's quite weird that same payload does not working
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to avoid generic names like Something
though, could you use a more descriptive name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
tendermint-rpc = { version = "0.32.0", features = ["http-client", "tokio"]} | ||
hpl-interface = "0.0.6-rc5" | ||
tendermint-rpc = { version = "0.32.0", features = ["http-client", "tokio"] } | ||
hpl-interface = "=0.0.6-rc3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, I'll merge it like this but let's open a follow-up PR to address when it's fixed
302c8e4
into
hyperlane-xyz:trevor/new-featv3-cosmos-oct-28
Description
Drive-by changes
Related issues
Backward compatibility
Testing