Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli gas preflight #2927

Merged
merged 6 commits into from
Nov 16, 2023
Merged

cli gas preflight #2927

merged 6 commits into from
Nov 16, 2023

Conversation

yorhodes
Copy link
Member

@yorhodes yorhodes commented Nov 16, 2023

Description

  • Check min gas on each chain in preflight

Drive-by changes

Related issues

Backward compatibility

Testing

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #2927 (841807b) into v3 (69d87c9) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##               v3    #2927   +/-   ##
=======================================
  Coverage   68.04%   68.04%           
=======================================
  Files          99       99           
  Lines        1017     1017           
  Branches      106      106           
=======================================
  Hits          692      692           
  Misses        286      286           
  Partials       39       39           
Components Coverage Δ
core 50.00% <ø> (ø)
hooks 71.42% <ø> (ø)
isms 71.22% <ø> (ø)
token 58.41% <ø> (ø)
middlewares 81.46% <ø> (ø)

Copy link
Contributor

@jmrossy jmrossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

typescript/cli/ci-test.sh Show resolved Hide resolved
typescript/cli/src/utils/balances.ts Show resolved Hide resolved
@yorhodes yorhodes merged commit cb93eb6 into v3 Nov 16, 2023
24 checks passed
@yorhodes yorhodes deleted the cli-gas-preflight branch November 16, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants