Convert packages from CJS to ESM #3531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes for core package
jmrossy
requested review from
tkporter,
nambrot,
yorhodes,
aroralanuk,
nbayindirli,
Skunkchain and
avious00
as code owners
🦋 Changeset detectedLatest commit: 3806e47 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3531 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 1 1
Lines 16 16
=====================================
Misses 16 16
|
jmrossy
commented
Apr 4, 2024
jmrossy
commented
Apr 4, 2024
jmrossy
commented
Apr 4, 2024
jmrossy
commented
Apr 4, 2024
jmrossy
commented
Apr 4, 2024
jmrossy
commented
Apr 4, 2024
jmrossy
commented
Apr 4, 2024
jmrossy
commented
Apr 4, 2024
jmrossy
commented
Apr 4, 2024
jmrossy
commented
Apr 4, 2024
Closed
nbayindirli
approved these changes
Apr 5, 2024
yorhodes
pushed a commit
that referenced
this pull request
Apr 14, 2024
### Description - Reconfigure tsconfig and package.json for the utils, core, sdk, and helloworld packages - Update imports to use ESM syntax - Add patch for typechain to address [issue 898](dethcrypto/TypeChain#898) ### Drive-by changes Improve package Readme content ### Related issues Fixes #1354 ### Backward compatibility No: package consumers using CJS will need to modify their imports or update to ESM. See [this popular gist](https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c#pure-esm-package) for details. ### Testing - [x] CI test coverage which invokes a lot of code via the CLI e2e - [x] Manually test in Warp UI by copying packages - [x] Publish beta packages and test in a few popular bundlers
letonchanh
pushed a commit
to letonchanh/hyperlane-monorepo
that referenced
this pull request
Apr 25, 2024
### Description - Reconfigure tsconfig and package.json for the utils, core, sdk, and helloworld packages - Update imports to use ESM syntax - Add patch for typechain to address [issue 898](dethcrypto/TypeChain#898) ### Drive-by changes Improve package Readme content ### Related issues Fixes hyperlane-xyz#1354 ### Backward compatibility No: package consumers using CJS will need to modify their imports or update to ESM. See [this popular gist](https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c#pure-esm-package) for details. ### Testing - [x] CI test coverage which invokes a lot of code via the CLI e2e - [x] Manually test in Warp UI by copying packages - [x] Publish beta packages and test in a few popular bundlers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drive-by changes
Improve package Readme content
Related issues
Fixes #1354
Backward compatibility
No: package consumers using CJS will need to modify their imports or update to ESM. See this popular gist for details.
Testing