Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chains/zksync #314

Merged
merged 9 commits into from
Nov 1, 2024
Merged

Chains/zksync #314

merged 9 commits into from
Nov 1, 2024

Conversation

mshojaei-txfusion
Copy link
Contributor

@mshojaei-txfusion mshojaei-txfusion commented Oct 21, 2024

Description

  • Added support for Sophon Sepolia Testnet integration.
  • Added support for ZKSync Sepolia Testnet integration.

Backward compatibility

compatible

Testing

Tested with cli

Copy link

changeset-bot bot commented Oct 21, 2024

🦋 Changeset detected

Latest commit: d458e00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hyperlane-xyz/registry Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JaunePomme
Copy link
Contributor

JaunePomme commented Oct 25, 2024

Changes required imo:

  • Changeset is missing,
  • Need to run the prettier,
  • Need to fetch the canonical main last changes too,
  • For both metadata file, the apiUrls are incorrect I think,
  • For both metadata file, the family name, I'm not sure it will be accepted (should be blockscout or other If I remember, someone will tell you)
  • For both address file, the file isn't alphabetically correctly ordered (merkleTree at the end of each file),
  • I see some width/height for the svg, not sure it's necessary and minimify them both with https://jakearchibald.github.io/svgomg/

Copy link
Contributor

@paulbalaji paulbalaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also add a minor changeset with yarn changeset add, and run yarn lint:fix and yarn prettier

chains/zksyncsepolia/metadata.yaml Outdated Show resolved Hide resolved
chains/zksyncsepolia/metadata.yaml Outdated Show resolved Hide resolved
chains/zksyncsepolia/metadata.yaml Outdated Show resolved Hide resolved
chains/zksyncsepolia/metadata.yaml Outdated Show resolved Hide resolved
chains/sophonsepolia/metadata.yaml Outdated Show resolved Hide resolved
chains/sophonsepolia/metadata.yaml Outdated Show resolved Hide resolved
chains/sophonsepolia/metadata.yaml Outdated Show resolved Hide resolved
chains/sophonsepolia/metadata.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@paulbalaji paulbalaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! just need to add the deployer metadata and we're good to merge

chains/sophonsepolia/metadata.yaml Show resolved Hide resolved
chains/zksyncsepolia/metadata.yaml Show resolved Hide resolved
@paulbalaji paulbalaji added this pull request to the merge queue Nov 1, 2024
Merged via the queue into hyperlane-xyz:main with commit e966856 Nov 1, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants