fix: remove oct16 chain deploy addresses #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7b39fba The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tkporter
approved these changes
Oct 30, 2024
github-merge-queue bot
pushed a commit
to hyperlane-xyz/hyperlane-monorepo
that referenced
this pull request
Nov 4, 2024
### Description - Updates the .registryrc, which we will need to update when we add new warp route configs to infra, otherwise we'll get ``` Checking warp route WBTC/eclipsemainnet-ethereum... Error checking warp route USDT/eclipsemainnet-ethereum-solanamainnet: Error: Warp route config for USDT/eclipsemainnet-ethereum-solanamainnet not found in registry Error checking warp route WBTC/eclipsemainnet-ethereum: Error: Warp route config for WBTC/eclipsemainnet-ethereum not found in registry Failed to check warp routes: USDT/eclipsemainnet-ethereum-solanamainnet, WBTC/eclipsemainnet-ethereum ``` - Uses the `Always` imagePullPolicy (https://kubernetes.io/docs/concepts/containers/images/#image-pull-policy) to ensure we always use latest main - A consequence of removing Lumia addresses from the registry in hyperlane-xyz/hyperlane-registry#348 is that this broke checking of the Lumia warp route. I manually specify the required addresses here now. - Also needed to explicitly specify the proxyAdmin ownership Definitely some opportunities for improvement with the warp route deploy flow ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: remove oct16 chain deploy addresses
Backward compatibility
no
Testing
manual