Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: documention of SATP package #3619

Open
wants to merge 1 commit into
base: satp-dev
Choose a base branch
from

Conversation

LordKubaya
Copy link
Contributor

No description provided.

@RafaelAPB RafaelAPB force-pushed the satp-dev branch 3 times, most recently from e377d8d to f6d15b5 Compare November 15, 2024 15:40
Copy link
Contributor

@RafaelAPB RafaelAPB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase adn solve conflicts

@RafaelAPB
Copy link
Contributor

@LordKubaya This LGTM. Are you still going to work on it (is it still a draft?)

@LordKubaya
Copy link
Contributor Author

@LordKubaya This LGTM. Are you still going to work on it (is it still a draft?)

Yes, I will be doing more work with documentation. But maybe this can be merged.

@petermetz
Copy link
Contributor

@LordKubaya If there's nothing in the current diff that still needs work then please merge it. I'm trying to reduce the time we have for open pull requests in general. Some of the official LFX stats can be seen here: https://insights.lfx.linuxfoundation.org/foundation/lf-decentralized-trust/velocity?project=cacti&routedFrom=Github&bestPractice=false

Copy link
Contributor

@RafaelAPB RafaelAPB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LordKubaya can you please rename the diagram you added? it seems to refer to stage 3, bridge specifics. I'd propose: gateway-message-flow-stage-3-bridge to be aligned with https://github.com/ietf-satp/draft-ietf-satp-core/tree/main/figures/message%20flow%20diagram

@RafaelAPB
Copy link
Contributor

I think we may merge. @LordKubaya please fix conflicts and we're good to go!

document(satp-hermes): Wrapper documentation

document(satp-hermes): Wrapper documentation

document(satp-hermes): Example contracts  documentation

docs: README changes

Signed-off-by: Carlos Amaro <carlosrscamaro@tecnico.ulisboa.pt>
@LordKubaya
Copy link
Contributor Author

@LordKubaya can you please rename the diagram you added? it seems to refer to stage 3, bridge specifics. I'd propose: gateway-message-flow-stage-3-bridge to be aligned with https://github.com/ietf-satp/draft-ietf-satp-core/tree/main/figures/message%20flow%20diagram

This is a end to end diagram, not just stage 3, or is there a confusion?

@LordKubaya LordKubaya marked this pull request as ready for review December 20, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants