-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: documention of SATP package #3619
base: satp-dev
Are you sure you want to change the base?
Conversation
e377d8d
to
f6d15b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase adn solve conflicts
@LordKubaya This LGTM. Are you still going to work on it (is it still a draft?) |
Yes, I will be doing more work with documentation. But maybe this can be merged. |
@LordKubaya If there's nothing in the current diff that still needs work then please merge it. I'm trying to reduce the time we have for open pull requests in general. Some of the official LFX stats can be seen here: https://insights.lfx.linuxfoundation.org/foundation/lf-decentralized-trust/velocity?project=cacti&routedFrom=Github&bestPractice=false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LordKubaya can you please rename the diagram you added? it seems to refer to stage 3, bridge specifics. I'd propose: gateway-message-flow-stage-3-bridge to be aligned with https://github.com/ietf-satp/draft-ietf-satp-core/tree/main/figures/message%20flow%20diagram
I think we may merge. @LordKubaya please fix conflicts and we're good to go! |
document(satp-hermes): Wrapper documentation document(satp-hermes): Wrapper documentation document(satp-hermes): Example contracts documentation docs: README changes Signed-off-by: Carlos Amaro <carlosrscamaro@tecnico.ulisboa.pt>
This is a end to end diagram, not just stage 3, or is there a confusion? |
No description provided.