-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update aries-vcx backchannel - aries_vcx: 0.64 #833
Conversation
Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
result of
compared to previous/
does not seem to have regressed |
Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
update: new result of runsets ariesvcx-ariesvcx after enabling 0023:
|
I'm happy to merge this. I ran both the old and the new running all the tests except those tagged Looks like the base branch can be updated, and then we can merge it.
|
Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
@swcurran thanks for taking the time to run it! to be honest, i'm a bit surprised there is regressions. which agents were you running there? vcx<->vcx? I'm just making some final updates to use a proper image tag ( |
Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
Alright, @swcurran i'm done with these changes, and happy to merge (if you're happy with it). i tried to clean up some of the runsets we have against ACAPy. There is still some inconsistent results i'm dealing with... this is probably a VCX problem though, i'll handle it there: hyperledger/aries-vcx#1252 |
^ also the ariesvcx-acapy runset (not the acapy-ariesvcx runset) is in a bad state due to vcx reporting the wrong state to the backchannel hyperledger/aries-vcx#1253 |
Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
Very happy with it -- looking great. Ran another test and a pile more successes. Nice! |
Changes backchannel image approach. Previously the aries-vcx repo AND the aries-agent-test-harness was maintaining the same backchannel codebase. It made sense for the repo to maintain the backchannel, as then breaking code changes could be immediately fixed. But it's a bit of a burden to have to sync the code between there and here.
Therefore this new approach is to have the aries-vcx repo be responsible for creating the backchannel image, then the image here simply consumes that backchannel image. This seems to match the approach of some other backchannels in this repo, such as
findy
.aries-vcx repo change to this approach: hyperledger/aries-vcx#1221
Closes #778