Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Verifiable Credential Data Integrity (VC-DI) Credentials in Aries Cloud Agent Python (ACA-Py) #2947

Closed
wants to merge 8 commits into from

Conversation

kenechukwu-orjiene
Copy link

No description provided.

supersonicwisd1 and others added 2 commits April 13, 2024 11:35
Signed-off-by: supersonicwisd1 <supersonicwisdom@gmail.com>
@kenechukwu-orjiene kenechukwu-orjiene marked this pull request as ready for review May 14, 2024 13:15
@dbluhm
Copy link
Member

dbluhm commented May 14, 2024

@jamshale given that this is just a doc update, I'm guessing the integration test failure is a fluke? Any insights?

@jamshale
Copy link
Contributor

@jamshale given that this is just a doc update, I'm guessing the integration test failure is a fluke? Any insights?

Yes. This is the one I've seen twice now. Somehow the integration test creates a race condition when setting the endorser's role. Very random.

Copy link
Member

@ianco ianco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is pretty high level, but I'll defer to @swcurran as to how much documentation is required.

I think there is more info required tho on the implementation, and a reference in the demo docs for how to select this credential type in the demo.

}
```

### Issue a Credential
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this section needs a bit more description, an example of ow to issue the credential and a high-level description of how the process works.

(Likewise for the present proof, which I assume will come after the implementation is complete.)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted. I should include that soon

Copy link

sonarcloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@dbluhm dbluhm marked this pull request as draft June 18, 2024 16:13
Signed-off-by: supersonicwisd1 <supersonicwisdom@gmail.com>
@ianco ianco requested a review from swcurran July 16, 2024 16:49
@supersonicwisd1
Copy link
Contributor

Overall this is pretty high level, but I'll defer to @swcurran as to how much documentation is required.

I think there is more info required tho on the implementation, and a reference in the demo docs for how to select this credential type in the demo.

Yes, I should add the select between indy and vc_di soon. Thank for the review.

Copy link

sonarcloud bot commented Jul 17, 2024

Signed-off-by: supersonicwisd1 <supersonicwisdom@gmail.com>
Signed-off-by: supersonicwisd1 <supersonicwisdom@gmail.com>
swcurran added a commit that referenced this pull request Jul 26, 2024
DOC: Verifiable Credential Data Integrity (VC-DI) Credentials in Aries Cloud Agent Python (ACA-Py) #2947
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants