-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Did
type in messages
crate
#1165
Labels
good first issue
Good for newcomers
Comments
Hello @Patrik-Stas I have created a PR #1171 for this. Apart from the instances resolved in the PR, there are multiple other instances in agent, misc, etc where did is typed as a string. Do I convert the PR to draft and add those instances as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
messages
https://github.com/hyperledger/aries-vcx/tree/main/aries/messages crate typically types DID attributes (for example in did-exchangeResponseContent
message type) asString
.did_parser_nom
's https://github.com/hyperledger/aries-vcx/tree/main/did_core/did_parser_nomDid
type instead so we parse&verify DIDs upon message deserialization.The text was updated successfully, but these errors were encountered: