Use Did type in message crate #1171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GHkrishna <kish77na@gmail.com>
…into fix/did-type Signed-off-by: GHkrishna <kish77na@gmail.com>
|
Hi @GHkrishna thank you for contribution! Sorry for delayed feedback, I've just enabled the CI run - as you can see the project doesn't compile now, you will need to sync up the rest of the codebase with these changes (won't be huge amount of work, but might be scattered across the board). Additionally you need to make sure your commits are signed off - see the failing DCO check https://github.com/hyperledger/aries-vcx/pull/1171/checks?check_run_id=23276330183 |
|
Closing due inactivity, feel free to reopen and continue later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1165
Use did_parser_nom's Did type in
messagecrates instead of string so as to parse & verify DIDs upon message deserialization