Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #1090 #1091 DID:SOV DIDDoc resolves without a service/endpoint and expands shorthand verkey notation for publicKeyBase58 #1105

Merged
merged 21 commits into from
Aug 7, 2024

Conversation

lukewli-anonyome
Copy link
Contributor

This PR introduces a fix for the DIDDoc resolution error outlined in issue #1090 and the shorthand verkey error outlined in issue #1091.

Closes #1090
Closes #1091

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (7614685) 0.05% compared to head (11828fa) 0.05%.
Report is 8 commits behind head on main.

Files Patch % Lines
aries/aries_vcx/src/common/signing.rs 0.00% 23 Missing ⚠️
...ries/misc/legacy/diddoc_legacy/src/aries/diddoc.rs 0.00% 4 Missing ⚠️
aries/aries_vcx/src/common/credentials/encoding.rs 0.00% 1 Missing ⚠️
...ies/aries_vcx/src/handlers/out_of_band/receiver.rs 0.00% 1 Missing ⚠️
aries/aries_vcx/src/handlers/util.rs 0.00% 1 Missing ⚠️
aries/aries_vcx/src/protocols/did_exchange/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1105      +/-   ##
========================================
- Coverage   0.05%   0.05%   -0.01%     
========================================
  Files        471     478       +7     
  Lines      24093   24334     +241     
  Branches    4332    4370      +38     
========================================
  Hits          13      13              
- Misses     24079   24320     +241     
  Partials       1       1              
Flag Coverage Δ
unittests-aries-vcx 0.05% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmulhearn-anonyome
Copy link
Contributor

weird that this clippy error is just showing up now :( maybe try fixing it (removing the dep)

@lukewli-anonyome lukewli-anonyome force-pushed the lli/DIDDocExpandVerKey branch 2 times, most recently from 9b411bd to 04e8133 Compare January 11, 2024 01:03
@Patrik-Stas
Copy link
Contributor

@lukewli-anonyome @gmulhearn-anonyome I am sorry folks for the conflicts that have arose after finally merging #1097

However, when you have bandwidth feel free to resume this effort

@lukewli-anonyome lukewli-anonyome force-pushed the lli/DIDDocExpandVerKey branch 2 times, most recently from f66b78c to 7e98f27 Compare July 24, 2024 00:08
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Copy link
Contributor

@gmulhearn gmulhearn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! thanks Luke

@gmulhearn gmulhearn merged commit b664ce7 into hyperledger:main Aug 7, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants