-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: #1090 #1091 DID:SOV DIDDoc resolves without a service/endpoint and expands shorthand verkey notation for publicKeyBase58 #1105
Fix: #1090 #1091 DID:SOV DIDDoc resolves without a service/endpoint and expands shorthand verkey notation for publicKeyBase58 #1105
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1105 +/- ##
========================================
- Coverage 0.05% 0.05% -0.01%
========================================
Files 471 478 +7
Lines 24093 24334 +241
Branches 4332 4370 +38
========================================
Hits 13 13
- Misses 24079 24320 +241
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
weird that this clippy error is just showing up now :( maybe try fixing it (removing the dep) |
9b411bd
to
04e8133
Compare
@lukewli-anonyome @gmulhearn-anonyome I am sorry folks for the conflicts that have arose after finally merging #1097 However, when you have bandwidth feel free to resume this effort |
f66b78c
to
7e98f27
Compare
Signed-off-by: lli <lli@anonyome.com>
2dd628c
to
8236c92
Compare
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
8236c92
to
623ceda
Compare
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! thanks Luke
This PR introduces a fix for the DIDDoc resolution error outlined in issue #1090 and the shorthand verkey error outlined in issue #1091.
Closes #1090
Closes #1091