Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] #1245 DIDExchange request handling should require invitation key rotation #1278

Merged
merged 7 commits into from
Aug 1, 2024

Conversation

lukewli-anonyome
Copy link
Contributor

This PR introduces a fix for the optional invitation key in DIDExchange handle_request described here in issue https://github.com/hyperledger/aries-vcx/issues/1245.

Closes #1245

Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
Signed-off-by: lli <lli@anonyome.com>
JamesKEbert
JamesKEbert previously approved these changes Aug 1, 2024
Copy link
Contributor

@JamesKEbert JamesKEbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- tests also passing locally. Nice work, thanks for the contribution!

gmulhearn
gmulhearn previously approved these changes Aug 1, 2024
Copy link
Contributor

@gmulhearn gmulhearn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! lgtm

Signed-off-by: lli <lli@anonyome.com>
@JamesKEbert JamesKEbert merged commit bd3a774 into hyperledger:main Aug 1, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIX] DIDExchange request handling should require invitation key rotation
3 participants