Skip to content

Commit

Permalink
Remove version update trigger on release (#1674)
Browse files Browse the repository at this point in the history
Version update should occur before creating the release otherwise release contain the content of previous version. Removed the version update workflow trigger on release. User need to run the version update workflow manually and merge the PR. Once PR is merged then new release should be created

Signed-off-by: Chaminda Divitotawela <cdivitotawela@gmail.com>
  • Loading branch information
cdivitotawela authored Aug 20, 2024
1 parent 7fe9ec1 commit 1654e36
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/update-version.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
name: Update Version

on:
release:
types: ["released"]
workflow_dispatch:
inputs:
version:
Expand All @@ -13,7 +11,7 @@ jobs:
update:
runs-on: ubuntu-latest
env:
VERSION: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.version || github.event.release.name }}
VERSION: ${{ github.event.inputs.version }}
permissions:
contents: write
pull-requests: write
Expand Down

0 comments on commit 1654e36

Please sign in to comment.