Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed null from engine_exchangeTransitionConfigurationV11 #1389

Merged
merged 4 commits into from
Aug 25, 2023

Conversation

Vikramop
Copy link
Contributor

No description provided.

@Vikramop Vikramop requested a review from a team as a code owner August 24, 2023 16:04
@vercel
Copy link

vercel bot commented Aug 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
besu-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 24, 2023 5:03pm

@alexandratran
Copy link
Contributor

@Vikramop can you fix the DCO error on this PR? https://github.com/hyperledger/besu-docs/pull/1389/checks?check_run_id=16185142637

For more context, see the Hyperledger contribution guidelines: https://wiki.hyperledger.org/display/BESU/DCO

alexandratran and others added 3 commits August 24, 2023 22:24
* doc new debug methods

Signed-off-by: Alexandra Tran <alexandra.tran@consensys.net>

* Apply suggestions from code review

Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Alexandra Tran Carrillo <12214231+alexandratran@users.noreply.github.com>

* add array

Signed-off-by: Alexandra Tran <alexandra.tran@consensys.net>

---------

Signed-off-by: Alexandra Tran <alexandra.tran@consensys.net>
Signed-off-by: Alexandra Tran Carrillo <12214231+alexandratran@users.noreply.github.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Veervikram singh <veervikramsingh132@gmail.com>
Signed-off-by: Veervikram singh <veervikramsingh132@gmail.com>
Signed-off-by: Veervikram singh <veervikramsingh132@gmail.com>
@Vikramop
Copy link
Contributor Author

Fixed DCO error.

Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandratran alexandratran merged commit 2654332 into hyperledger:main Aug 25, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants