fix the linter

Signed-off-by: hfuss <hayden.fuss@kaleido.io>
hyperledger · Dec 13, 2024 · 34ccee1 · 34ccee1
1 parent 8008940
commit 34ccee1
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 6 deletions.
diff --git a/firefly-common.iml b/firefly-common.iml
@@ -0,0 +1,10 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<module type="WEB_MODULE" version="4">
+  <component name="Go" enabled="true" />
+  <component name="NewModuleRootManager" inherit-compiler-output="true">
+    <exclude-output />
+    <content url="file://$MODULE_DIR$" />
+    <orderEntry type="inheritedJdk" />
+    <orderEntry type="sourceFolder" forTests="false" />
+  </component>
+</module>
diff --git a/pkg/metric/prometheusMetricsManager.go b/pkg/metric/prometheusMetricsManager.go
@@ -26,7 +26,9 @@ import (
 	"github.com/prometheus/client_golang/prometheus"
 )
 
-var supportedTypes = []string{"counterVec", "gaugeVec", "histogramVec", "summaryVec"}
+const gaugeVec = "gaugeVec"
+
+var supportedTypes = []string{"counterVec", gaugeVec, "histogramVec", "summaryVec"}
 
 const fireflySystemLabelsPrefix = "ff_"
 const namespaceLabel = fireflySystemLabelsPrefix + "namespace"
@@ -109,7 +111,7 @@ func (pmm *prometheusMetricsManager) NewGaugeMetric(ctx context.Context, metricN
 }
 func (pmm *prometheusMetricsManager) NewGaugeMetricWithLabels(ctx context.Context, metricName string, helpText string, labelNames []string, withDefaultLabels bool) {
 	pmm.registerMetrics(ctx, regInfo{
-		Type:       "gaugeVec",
+		Type:       gaugeVec,
 		Name:       metricName,
 		HelpText:   helpText,
 		LabelNames: checkAndUpdateLabelNames(ctx, labelNames, withDefaultLabels),
@@ -182,7 +184,7 @@ func (pmm *prometheusMetricsManager) registerMetrics(ctx context.Context, mr reg
 			}, mr.LabelNames),
 			LabelNames: mr.LabelNames,
 		}
-	case "gaugeVec":
+	case gaugeVec:
 		pmm.metricsMap[internalMapIndex] = &prometheusMetric{
 			Metric: prometheus.NewGaugeVec(prometheus.GaugeOpts{
 				Namespace: pmm.namespace,
@@ -232,7 +234,7 @@ func (pmm *prometheusMetricsManager) DecGaugeMetric(ctx context.Context, metricN
 }
 
 func (pmm *prometheusMetricsManager) SetGaugeMetricWithLabels(ctx context.Context, metricName string, number float64, labels map[string]string, defaultLabels *FireflyDefaultLabels) {
-	m, ok := pmm.metricsMap[metricName+"_gaugeVec"]
+	m, ok := pmm.metricsMap[metricName+"_"+gaugeVec]
 	if !ok {
 		log.L(ctx).Warnf("metric with name: '%s' and type: '%s' is not found", metricName, "gaugeVec")
 	} else {
@@ -243,7 +245,7 @@ func (pmm *prometheusMetricsManager) SetGaugeMetricWithLabels(ctx context.Contex
 }
 
 func (pmm *prometheusMetricsManager) IncGaugeMetricWithLabels(ctx context.Context, metricName string, labels map[string]string, defaultLabels *FireflyDefaultLabels) {
-	m, ok := pmm.metricsMap[metricName+"_gaugeVec"]
+	m, ok := pmm.metricsMap[metricName+"_"+gaugeVec]
 	if !ok {
 		log.L(ctx).Warnf("metric with name: '%s' and type: '%s' is not found", metricName, "gaugeVec")
 	} else {
@@ -254,7 +256,7 @@ func (pmm *prometheusMetricsManager) IncGaugeMetricWithLabels(ctx context.Contex
 }
 
 func (pmm *prometheusMetricsManager) DecGaugeMetricWithLabels(ctx context.Context, metricName string, labels map[string]string, defaultLabels *FireflyDefaultLabels) {
-	m, ok := pmm.metricsMap[metricName+"_gaugeVec"]
+	m, ok := pmm.metricsMap[metricName+"_"+gaugeVec]
 	if !ok {
 		log.L(ctx).Warnf("metric with name: '%s' and type: '%s' is not found", metricName, "gaugeVec")
 	} else {