Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ExportableKey): adding ExportableKey protocol and implementation #131

Merged
merged 1 commit into from
Dec 4, 2023
Merged

feat(ExportableKey): adding ExportableKey protocol and implementation #131

merged 1 commit into from
Dec 4, 2023

Conversation

curtis-h
Copy link
Contributor

@curtis-h curtis-h commented Nov 28, 2023 •
edited
Loading

Description

Define and implement ExportableKey and ImportableKey.

  • Added ExportableKey interface and namespace

    • used factory functions to create Key property

  • Added JWK

    • definitions and functions to convert Keys to and from an JWK OKP

  • Added PEM

    • functions to convert to and from a PEM string

  • Key

    • moved curve property from PrivateKey / PublicKey to Key
    • added abstract for common exports Buffer and String

  • Unit tests

Jira link

https://input-output.atlassian.net/browse/ATL-5865

Checklist

  • Self-reviewed the diff
  • New code has inline documentation
  • New code has proper comments/tests
  • Any changes not covered by tests have been tested manually

@curtis-h curtis-h self-assigned this Nov 28, 2023
@github-actions GitHub Actions
Copy link

Lines Statements Branches Functions
Coverage: 37%
 37.19% (1637/4401) 26.07% (726/2784) 40.18% (508/1264)

JUnit

Tests Skipped Failures Errors Time
319 2 💤 0 ❌ 0 🔥 1m 1s ⏱️

@curtis-h curtis-h changed the title feat(Apollo): adding ExportableKey protocol and implementation feat(ExportableKey): adding ExportableKey protocol and implementation Nov 30, 2023
goncalo-frade-iohk
goncalo-frade-iohk approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@goncalo-frade-iohk goncalo-frade-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome mate. I need to create the ticket for the inconsistencies you found on Swift. Gj

elribonazo
elribonazo approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@elribonazo elribonazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful

@curtis-h curtis-h merged commit 3487815 into master Dec 4, 2023
4 checks passed
@curtis-h curtis-h deleted the feature/ATL-5865-exportableKey branch December 4, 2023 10:11
mixmix pushed a commit to mixmix/atala-prism-wallet-sdk-ts that referenced this pull request May 6, 2024
@curtis-h @elribonazo
feat(ExportableKey): adding ExportableKey protocol and implementation (…
474e7ec 
…hyperledger#131)

Signed-off-by: Francisco Javier Ribó Labrador <elribonazo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elribonazo elribonazo elribonazo approved these changes

@goncalo-frade-iohk goncalo-frade-iohk goncalo-frade-iohk approved these changes

Assignees

@curtis-h curtis-h

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@curtis-h @elribonazo @goncalo-frade-iohk