feat(graphql): allow updatable and nullable @id fields. (#7736) #9020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangalaman93
requested review from
meghalims,
harshil-goel,
all-seeing-code,
billprovince and
joshua-goldstein
as code owners
dgraph-bot
added
area/testing
Currently, @id fields are not updatable and also we enforce them to be non-null. In this PR we are allowing @id fields to be updatable and nullable. RFC: https://discuss.dgraph.io/t/rfc-mutable-and-null-able-id-field-in-graphql/13663 Related Posts: https://discuss.dgraph.io/t/nullable-id-field/13296 https://discuss.dgraph.io/t/editable-id-fields/13295 https://discuss.dgraph.io/t/rfc-allow-multiple-unique-fields-in-graphql-schema/12008
harshil-goel
approved these changes
Dec 8, 2023
shivaji-kharse
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, @id fields are not updatable and also we enforce them to be non-null. In this PR we are allowing @id fields to be updatable and nullable.
RFC:
https://discuss.dgraph.io/t/rfc-mutable-and-null-able-id-field-in-graphql/13663
Related Posts:
https://discuss.dgraph.io/t/nullable-id-field/13296
https://discuss.dgraph.io/t/editable-id-fields/13295
https://discuss.dgraph.io/t/rfc-allow-multiple-unique-fields-in-graphql-schema/12008