-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding otlp_http trace exporter #231
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why codecov is having issues?
Its printing that it got rate limited. Maybe the licensing issue we face in our org as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Can you ask in engineering channel? Maybe there's an answer. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #231 +/- ##
==========================================
- Coverage 60.15% 59.18% -0.97%
==========================================
Files 69 69
Lines 2753 2291 -462
==========================================
- Hits 1656 1356 -300
+ Misses 1019 857 -162
Partials 78 78 ☔ View full report in Codecov by Sentry. |
Upgrading the codecov version fixed it |
Description
Noticed it while creating the ecs template for TPA. Goagent as of now doesnt support otlp over http. Adding that support here.
Testing
Tested both TLS and non TLS connection to TPA
Checklist: