Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding otlp_http trace exporter #231

Merged
merged 6 commits into from
Jun 5, 2024
Merged

Conversation

varkey98
Copy link
Contributor

@varkey98 varkey98 commented Jun 4, 2024

Description

Noticed it while creating the ecs template for TPA. Goagent as of now doesnt support otlp over http. Adding that support here.

Testing

Tested both TLS and non TLS connection to TPA

Checklist:

  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@varkey98 varkey98 changed the title feat: adding otlp_http exporter feat: adding otlp_http trace exporter Jun 4, 2024
Copy link
Collaborator

@tim-mwangi tim-mwangi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why codecov is having issues?

@varkey98
Copy link
Contributor Author

varkey98 commented Jun 4, 2024

I wonder why codecov is having issues?

Its printing that it got rate limited. Maybe the licensing issue we face in our org as well?

Copy link
Collaborator

@ryanericson ryanericson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@tim-mwangi
Copy link
Collaborator

I wonder why codecov is having issues?

Its printing that it got rate limited. Maybe the licensing issue we face in our org as well?

Can you ask in engineering channel? Maybe there's an answer.

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 59.18%. Comparing base (3224ad8) to head (b90a292).

Files Patch % Lines
instrumentation/opentelemetry/init.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
- Coverage   60.15%   59.18%   -0.97%     
==========================================
  Files          69       69              
  Lines        2753     2291     -462     
==========================================
- Hits         1656     1356     -300     
+ Misses       1019      857     -162     
  Partials       78       78              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@varkey98 varkey98 requested a review from senanjude0 June 5, 2024 05:55
@varkey98 varkey98 merged commit 70d260f into hypertrace:main Jun 5, 2024
2 of 6 checks passed
@varkey98
Copy link
Contributor Author

varkey98 commented Jun 5, 2024

I wonder why codecov is having issues?

Its printing that it got rate limited. Maybe the licensing issue we face in our org as well?

Can you ask in engineering channel? Maybe there's an answer.

Upgrading the codecov version fixed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants