order installers, filter components should be after configs (#384)

hypertrace · Apr 27, 2023 · 777d4b1 · 777d4b1
1 parent c66faa5
commit 777d4b1
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 0 deletions.
diff --git a/...tensions/src/main/java/org/hypertrace/agent/otel/extensions/FilterComponentInstaller.java b/...tensions/src/main/java/org/hypertrace/agent/otel/extensions/FilterComponentInstaller.java
@@ -43,4 +43,10 @@ public void beforeAgent(AutoConfiguredOpenTelemetrySdk autoConfiguredOpenTelemet
     // resolves filter via service loader resolution
     FilterRegistry.initialize(providerConfig, jarPaths, getClass().getClassLoader());
   }
+
+  @Override
+  public int order() {
+    // Configs should be loaded before FilterComponents because filters use configs
+    return 1;
+  }
 }
diff --git a/...src/main/java/org/hypertrace/agent/otel/extensions/config/DataCaptureConfigInstaller.java b/...src/main/java/org/hypertrace/agent/otel/extensions/config/DataCaptureConfigInstaller.java
@@ -29,4 +29,10 @@ public class DataCaptureConfigInstaller implements BeforeAgentListener {
   public void beforeAgent(AutoConfiguredOpenTelemetrySdk autoConfiguredOpenTelemetrySdk) {
     ConfigProvider.get(getClass().getClassLoader());
   }
+
+  @Override
+  public int order() {
+    // Configs should be loaded before FilterComponents because filters use configs
+    return 0;
+  }
 }
diff --git a/...main/java/org/hypertrace/agent/otel/extensions/config/InstrumentationConfigInstaller.java b/...main/java/org/hypertrace/agent/otel/extensions/config/InstrumentationConfigInstaller.java
@@ -28,4 +28,10 @@ public class InstrumentationConfigInstaller implements BeforeAgentListener {
   public void beforeAgent(AutoConfiguredOpenTelemetrySdk autoConfiguredOpenTelemetrySdk) {
     ConfigProvider.get(getClass().getClassLoader());
   }
+
+  @Override
+  public int order() {
+    // Configs should be loaded before FilterComponents because filters use configs
+    return 0;
+  }
 }
diff --git a/...s/src/main/java/org/hypertrace/agent/otel/extensions/config/ReportingConfigInstaller.java b/...s/src/main/java/org/hypertrace/agent/otel/extensions/config/ReportingConfigInstaller.java
@@ -28,4 +28,10 @@ public class ReportingConfigInstaller implements BeforeAgentListener {
   public void beforeAgent(AutoConfiguredOpenTelemetrySdk autoConfiguredOpenTelemetrySdk) {
     ConfigProvider.get(getClass().getClassLoader());
   }
+
+  @Override
+  public int order() {
+    // Configs should be loaded before FilterComponents because filters use configs
+    return 0;
+  }
 }