upgrade jackson, shaded, gradle versions #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanericson
approved these changes
Dec 11, 2023
build.gradle.kts
Outdated
| } | ||
|
|
||
| repositories { | ||
| mavenCentral() | ||
| configurations { |
There was a problem hiding this comment.
What's the purpose of this block? Where are we including a gradle plugin in the dependency classpath for example?
build.gradle.kts
Outdated
| } | ||
|
|
||
| tasks.withType<Jar> { | ||
| duplicatesStrategy = DuplicatesStrategy.FAIL |
There was a problem hiding this comment.
isn't this the default now? is there a reason it was added?
buildSrc/build.gradle.kts
Outdated
| } | ||
| } | ||
|
|
||
| configurations { |
There was a problem hiding this comment.
seems like maybe those root changes you applied to all are really relevant in the buildSrc vs the actual code?
tim-mwangi
approved these changes
Dec 12, 2023
shashank11p
requested review from
aaron-steinfeld,
ryanericson and
tim-mwangi
tim-mwangi
approved these changes
Dec 12, 2023
aaron-steinfeld
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.