Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove high cardinality metrics #406

Merged
merged 5 commits into from
Sep 9, 2024
Merged

feat: remove high cardinality metrics #406

merged 5 commits into from
Sep 9, 2024

Conversation

thugrock7
Copy link
Contributor

Description

Do not record high cardinality attributes in metrics which could potentially cause max cardinality errors and lead to drop of all attributes

@thugrock7 thugrock7 requested a review from shashank11p August 19, 2024 14:01
shashank11p
shashank11p reviewed Aug 26, 2024
View reviewed changes
Copy link
Contributor

@shashank11p shashank11p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some tests for metrics as well. Maybe in smoke tests. We already have checks for some metrics. We can check for attributes in metrics there as well

@thugrock7 thugrock7 merged commit 5813589 into hypertrace:main Sep 9, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shashank11p shashank11p shashank11p approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thugrock7 @shashank11p