Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: servlet 5.0 body capture fix #411

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: servlet 5.0 body capture fix #411

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9c7a76
flush to get all headers
thugrock7 Dec 17, 2024
8f09356
spotless apply
thugrock7 Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .../javaagent/instrumentation/hypertrace/servlet/v5_0/Servlet50AndFilterInstrumentation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,9 @@ public static void exit(

if (!request.isAsyncStarted()) {
if (instrumentationConfig.httpHeaders().response()) {
if (throwable == null && !httpResponse.isCommitted()) {
httpResponse.flushBuffer();
}
for (String headerName : httpResponse.getHeaderNames()) {
String headerValue = httpResponse.getHeader(headerName);
currentSpan.setAttribute(
Expand Down Expand Up @@ -216,6 +219,7 @@ public static void exit(
urlEncodedMapContextStore);
}
}
} catch (IOException ignored) {
} finally {
Throwable tmp = throwable;
while (tmp != null) { // loop in case our exception is nested (eg. springframework)
Expand Down
Loading