Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: calculator tool #10

Merged
merged 43 commits into from
Sep 6, 2024
Merged

feat: calculator tool #10

merged 43 commits into from
Sep 6, 2024

Conversation

michael-desmond
Copy link
Contributor

Calculator tool based on mathjs

Copy link
Contributor

@Tomas2D Tomas2D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚀

Please rebase against main + add a simple test case.

src/tools/calculator.ts Outdated Show resolved Hide resolved
src/tools/calculator.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@matoushavlena matoushavlena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tomas2D Is there any guidance on using Web Workers for tools that might have impact on CPU/memory?

src/tools/calculator.ts Outdated Show resolved Hide resolved
src/tools/calculator.ts Outdated Show resolved Hide resolved
src/tools/calculator.ts Outdated Show resolved Hide resolved
src/tools/calculator.ts Outdated Show resolved Hide resolved
src/tools/calculator.ts Outdated Show resolved Hide resolved
src/tools/calculator.ts Outdated Show resolved Hide resolved
src/tools/calculator.ts Outdated Show resolved Hide resolved
src/tools/calculator.ts Outdated Show resolved Hide resolved
src/tools/calculator.ts Outdated Show resolved Hide resolved
@Tomas2D
Copy link
Contributor

Tomas2D commented Sep 5, 2024

Please rebase against main.

Tomas2D

This comment was marked as resolved.

@Tomas2D Tomas2D merged commit 2af8af7 into i-am-bee:main Sep 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants